Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token not being redacted from error log #1792

Merged
merged 2 commits into from
Feb 22, 2025
Merged

Fix token not being redacted from error log #1792

merged 2 commits into from
Feb 22, 2025

Conversation

Sjmarf
Copy link
Member

@Sjmarf Sjmarf commented Feb 22, 2025

Fixes #1788

@Sjmarf Sjmarf requested a review from a team as a code owner February 22, 2025 16:08
@Sjmarf Sjmarf requested review from EricBAndrews and removed request for a team February 22, 2025 16:08
EricBAndrews
EricBAndrews approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Sjmarf Sjmarf enabled auto-merge (squash) February 22, 2025 17:45
@Sjmarf Sjmarf merged commit 15a6f94 into dev Feb 22, 2025
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/token-redaction branch February 22, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth tokens not always redacted from error log
2 participants
@Sjmarf @EricBAndrews