add bool type; remove call to debugger and raise exception on unexpec…

…ted kind from jsonl
mlfoundations · Feb 14, 2024 · 6ff4979 · 6ff4979
1 parent 4553f8c
commit 6ff4979
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/tableshift/core/features.py b/tableshift/core/features.py
@@ -200,14 +200,13 @@ def from_jsonl(cls, file: str, auto_cast_value_mappings: bool = False):
 
         for i in range(len(feature_dicts)):
             kind = feature_dicts[i]['kind']
-            if kind in ('float', 'int'):
+            if kind in ('float', 'int', 'bool'):
                 feature_dicts[i]['kind'] = eval(kind)
             elif kind == "category":
                 feature_dicts[i]['kind'] = cat_dtype
             else:
-                print(f"unexpected kind: {kind}")
-                import ipdb;
-                ipdb.set_trace()
+                raise ValueError(f"unexpected kind: {kind}")
+
         features = [Feature(**feature_dict) for feature_dict in feature_dicts]
         return cls(features=features)