Skip to content

Commit

Permalink
add TOCHECK comment on benchmark design
Browse files Browse the repository at this point in the history
  • Loading branch information
bblodfon committed Nov 5, 2024
1 parent 6f3923f commit 123624e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions R/embedded_ensemble_fselect.R
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ embedded_ensemble_fselect = function(
)
})

# TOCHECK: can we have `task` as the original task here,
# `resampling` the subsamples (train/test partitions) so that
# bmr$score(measure) later just works out of the box?
design = grid[, c("learner", "task", "resampling"), with = FALSE]

bmr = benchmark(design, store_models = TRUE)
Expand Down

0 comments on commit 123624e

Please sign in to comment.