Skip to content

Commit 41ec373

Browse files
committed
Fix filter icon does not update if output/track is not selected
Steps to reproduce: 1 Add a filter to a track or output 2 select something else 3 Undo Observe that the filter icon does not update
1 parent a71e8ca commit 41ec373

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/models/attachedfiltersmodel.cpp

+2-5
Original file line numberDiff line numberDiff line change
@@ -625,8 +625,6 @@ void AttachedFiltersModel::doAddService(Mlt::Producer &producer, Mlt::Service &s
625625
QmlMetadata *meta = MAIN.filterController()->metadataForService(&service);
626626
m_metaList.insert(row, meta);
627627
endInsertRows();
628-
emit addedOrRemoved(m_producer.data());
629-
630628
} else {
631629
producer.attach(filter);
632630
producer.move_filter(producer.filter_count() - 1, mltIndex);
@@ -653,7 +651,6 @@ void AttachedFiltersModel::doAddService(Mlt::Producer &producer, Mlt::Service &s
653651
QmlMetadata *meta = MAIN.filterController()->metadataForService(&service);
654652
m_metaList.insert(row, meta);
655653
endInsertRows();
656-
emit addedOrRemoved(m_producer.data());
657654
} else {
658655
chain.attach(link);
659656
chain.move_link(chain.link_count() - 1, mltIndex);
@@ -664,6 +661,7 @@ void AttachedFiltersModel::doAddService(Mlt::Producer &producer, Mlt::Service &s
664661
LOG_ERROR() << "invalid service type" << service.type();
665662
break;
666663
}
664+
emit addedOrRemoved(&producer);
667665
}
668666

669667
void AttachedFiltersModel::remove(int row)
@@ -704,7 +702,6 @@ void AttachedFiltersModel::doRemoveService(Mlt::Producer &producer, int row)
704702
m_event->unblock();
705703
m_metaList.removeAt(row);
706704
endRemoveRows();
707-
emit addedOrRemoved(m_producer.get());
708705
} else {
709706
chain.detach(*link);
710707
}
@@ -719,7 +716,6 @@ void AttachedFiltersModel::doRemoveService(Mlt::Producer &producer, int row)
719716
m_event->unblock();
720717
m_metaList.removeAt(row);
721718
endRemoveRows();
722-
emit addedOrRemoved(m_producer.get());
723719
} else {
724720
producer.detach(*filter);
725721
}
@@ -728,6 +724,7 @@ void AttachedFiltersModel::doRemoveService(Mlt::Producer &producer, int row)
728724
} else {
729725
LOG_WARNING() << "invalid service:" << producer.type();
730726
}
727+
emit addedOrRemoved(&producer);
731728
}
732729

733730
bool AttachedFiltersModel::move(int fromRow, int toRow)

0 commit comments

Comments
 (0)