Fix Pasting filters does not create history

As reported here:
https://forum.shotcut.org/t/pasting-filters-does-not-create-history/47308

Author: bmatherly

src/commands/filtercommands.cpp

@@ -21,6 +21,7 @@
 #include "controllers/filtercontroller.h"
 #include "mainwindow.h"
 #include "mltcontroller.h"
+#include "qmltypes/qmlapplication.h"
 #include "qmltypes/qmlmetadata.h"
 
 class FindProducerParser : public Mlt::Parser
@@ -291,6 +292,55 @@ bool DisableCommand::mergeWith(const QUndoCommand *other)
     */
 }
 
+PasteCommand::PasteCommand(AttachedFiltersModel &model,
+                           const QString &filterProducerXml,
+                           QUndoCommand *parent)
+    : QUndoCommand(parent)
+    , m_model(model)
+    , m_xml(filterProducerXml)
+    , m_producerUuid(MLT.ensureHasUuid(*model.producer()))
+{
+    setText(QObject::tr("Paste filters"));
+    m_beforeXml = MLT.XML(model.producer());
+}
+
+void PasteCommand::redo()
+{
+    LOG_DEBUG() << text();
+    Mlt::Producer producer = findProducer(m_producerUuid);
+    Q_ASSERT(producer.is_valid());
+    Mlt::Profile profile(kDefaultMltProfile);
+    Mlt::Producer filtersProducer(profile, "xml-string", m_xml.toUtf8().constData());
+    if (filtersProducer.is_valid() && filtersProducer.filter_count() > 0) {
+        MLT.pasteFilters(&producer, &filtersProducer);
+    }
+    emit QmlApplication::singleton().filtersPasted(&producer);
+}
+
+void PasteCommand::undo()
+{
+    LOG_DEBUG() << text();
+    Mlt::Producer producer = findProducer(m_producerUuid);
+    Q_ASSERT(producer.is_valid());
+    // Remove all filters
+    for (int i = 0; i < producer.filter_count(); i++) {
+        Mlt::Filter *filter = producer.filter(i);
+        if (filter && filter->is_valid() && !filter->get_int("_loader")
+            && !filter->get_int(kShotcutHiddenProperty)) {
+            producer.detach(*filter);
+            i--;
+        }
+        delete filter;
+    }
+    // Restore the "before" filters
+    Mlt::Profile profile(kDefaultMltProfile);
+    Mlt::Producer filtersProducer(profile, "xml-string", m_beforeXml.toUtf8().constData());
+    if (filtersProducer.is_valid() && filtersProducer.filter_count() > 0) {
+        MLT.pasteFilters(&producer, &filtersProducer);
+    }
+    emit QmlApplication::singleton().filtersPasted(&producer);
+}
+
 UndoParameterCommand::UndoParameterCommand(const QString &name,
                                            FilterController *controller,
                                            int row,

src/commands/filtercommands.h

@@ -136,6 +136,22 @@ class DisableCommand : public QUndoCommand
     bool m_disabled;
 };
 
+class PasteCommand : public QUndoCommand
+{
+public:
+    PasteCommand(AttachedFiltersModel &model,
+                 const QString &filterProducerXml,
+                 QUndoCommand *parent = 0);
+    void redo();
+    void undo();
+
+private:
+    AttachedFiltersModel &m_model;
+    QString m_xml;
+    QString m_beforeXml;
+    QUuid m_producerUuid;
+};
+
 class UndoParameterCommand : public QUndoCommand
 {
 public:

src/docks/filtersdock.cpp

@@ -264,7 +264,7 @@ void FiltersDock::setupActions()
     icon = QIcon::fromTheme("edit-paste", QIcon(":/icons/oxygen/32x32/actions/edit-paste.png"));
     action->setIcon(icon);
     connect(action, &QAction::triggered, this, [=]() {
-        QmlApplication::singleton().pasteFilters();
+        MAIN.filterController()->attachedModel()->pasteFilters();
     });
     addAction(action);
     Actions.add("filtersPasteFiltersAction", action, windowTitle());

src/mainwindow.cpp

@@ -3480,6 +3480,7 @@ void MainWindow::onProducerModified()
 {
     setWindowModified(true);
     sourceUpdated();
+    MLT.refreshConsumer();
 }
 
 void MainWindow::onFilterModelChanged()

src/models/attachedfiltersmodel.cpp

@@ -739,6 +739,16 @@ bool AttachedFiltersModel::move(int fromRow, int toRow)
     return moveRows(parent, fromRow, 1, parent, toRow);
 }
 
+void AttachedFiltersModel::pasteFilters()
+{
+    if (m_producer && QmlApplication::confirmOutputFilter()) {
+        QString s = QGuiApplication::clipboard()->text();
+        if (MLT.isMltXml(s)) {
+            MAIN.undoStack()->push(new Filter::PasteCommand(*this, s));
+        }
+    }
+}
+
 void AttachedFiltersModel::reset(Mlt::Producer *producer)
 {
     beginResetModel();

src/models/attachedfiltersmodel.h

@@ -85,6 +85,7 @@ public slots:
     int addService(Mlt::Service *service);
     void remove(int row);
     bool move(int fromRow, int toRow);
+    void pasteFilters();
 
 private:
     static void producerChanged(mlt_properties owner, AttachedFiltersModel *model);

src/qml/views/filter/filterview.qml

@@ -241,7 +241,7 @@ Rectangle {
             opacity: enabled ? 1 : 0.5
             icon.name: 'edit-paste'
             icon.source: 'qrc:///icons/oxygen/32x32/actions/edit-paste.png'
-            onClicked: application.pasteFilters()
+            onClicked: attachedfiltersmodel.pasteFilters()
 
             Shotcut.HoverTip {
                 text: qsTr('Paste filters')

src/qmltypes/qmlapplication.cpp

@@ -140,29 +140,6 @@ void QmlApplication::copyCurrentFilter()
     emit QmlApplication::singleton().filtersCopied();
 }
 
-void QmlApplication::pasteFilters()
-{
-    QScopedPointer<Mlt::Producer> producer(
-        new Mlt::Producer(MAIN.filterController()->attachedModel()->producer()));
-    if (confirmOutputFilter()) {
-        QString s = QGuiApplication::clipboard()->text();
-        if (MLT.isMltXml(s)) {
-            Mlt::Profile profile(kDefaultMltProfile);
-            Mlt::Producer filtersProducer(profile, "xml-string", s.toUtf8().constData());
-            if (filtersProducer.is_valid() && filtersProducer.filter_count() > 0
-                && filtersProducer.get_int(kShotcutFiltersClipboard)) {
-                MLT.pasteFilters(producer.get(), &filtersProducer);
-            } else {
-                MLT.pasteFilters(producer.data());
-            }
-        } else {
-            MLT.pasteFilters(producer.data());
-        }
-        emit QmlApplication::singleton().filtersPasted(
-            MAIN.filterController()->attachedModel()->producer());
-    }
-}
-
 QString QmlApplication::clockFromFrames(int frames)
 {
     if (MLT.producer()) {

src/qmltypes/qmlapplication.h

@@ -54,7 +54,6 @@ class QmlApplication : public QObject
     Q_INVOKABLE static void copyAllFilters();
     Q_INVOKABLE static void copyEnabledFilters();
     Q_INVOKABLE static void copyCurrentFilter();
-    Q_INVOKABLE static void pasteFilters();
     Q_INVOKABLE static QString clockFromFrames(int frames);
     Q_INVOKABLE static QString timeFromFrames(int frames);
     Q_INVOKABLE static int audioChannels();