-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pressing and holding Enter-key in playlist on a single mp4 test video seems to generate memory leak #673
Comments
This is not a build created and supported by us. I do not know the version of MLT used in this, and that might be a factor as I did not reproduce this on macOS. I will try on Linux next using one of our builds. |
I only experienced something extremely minor on Linux using my build with MLT 6.12.0, RES: 271366 -> 310308 when holding Enter for 2 minutes. |
I've also tested with flatpak build now. Current top info: RES 2,5g and VIRT 7739,2m Tracing memory access when pressing Enter on test-file in playlist: I see mmap of 8392704 bytes at 0x7f7026fe0000 and then later madvise DONTNEED of 8368128 bytes. I cannot see any release of the mmap for 0x7f7027fe2000 memory. 5 shotcut cloned threads (25784-25788) and 1 'Thread (pooled)' 25789
Tracing file access: It seems like duplicate stats are run, two open calls for mp4 file ? strace -e trace=file -f -p $(pgrep shotcut)
` |
The flatpak uses the MLT git master from the date of the build. So, the big difference between what you are testing and myself is Qt version. The v18.11.18 flatpak (and probably also your Fedora package) of Shotcut uses Qt 5.11 while mine and the other builds (portable and appimage) are using Qt 5.6.
Yes, each audio/video file is opened twice with libavformat in order to maintain a/v synchronization while seeking. Ideally, it should not be needed, but that is the way it is with no plans to change it. |
I've tested holding the Enter key (for at least 30-60 seconds) on a single file in the playlist. It seems like its leaking some memory (RES is now on 3,1g). Maybe this can lead to problems when navigating the playlist during editing.
Shotcut-version : 18.11.18.02 (disabled GPU effects)
Fedora: 29
top -p $(pgrep shotcut)
The text was updated successfully, but these errors were encountered: