Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0. #5026

Open
f18m opened this issue Nov 8, 2024 · 3 comments

Comments

@f18m
Copy link

f18m commented Nov 8, 2024

Theme version and system environment

  • Minimal Mistakes version: 4.26.2
  • Ruby gem or remote theme version: 3.3.5
  • Jekyll version: 4.3.4
  • Git repository URL: https://github.com/f18m/f18m.github.io
  • URL to the page with the problem:
  • Operating system:
  • Browser version:

What happened?

I'm using the "dark" skin and when I launch Jekyll to serve the website I see these:

Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

  ╷
3 │ @import "minimal-mistakes/skins/dark"; // skin
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
    /home/fmontorsi/Documents/f18m.github.io/assets/css/main.scss 3:9  root stylesheet
Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

  ╷
4 │ @import "minimal-mistakes"; // main partials
  │         ^^^^^^^^^^^^^^^^^^
  ╵

Expected behavior

No deprecation warnings

Steps to reproduce the behavior

  • install minimal mistakes theme
  • enable the 'dark' skin
  • run 'bundle exec jekyll serve'

Other

No response

@lsolesen
Copy link
Contributor

Seems to be mentioned here also: #4303

@bewuethr
Copy link

Seems to be mentioned here also: #4303

Which in turn is a duplicate of #4054 🙃

@adrianhall
Copy link

To tag along with this:

  • Susy is deprecated and will no longer receive updates. This is the grid system that mmistakes uses.

Doing the switch over to modules is relatively painless, but requires a custom github action (otherwise horrible things happen), and I'm happy to produce a PR. Based on comments in other issues, it wouldn't be integrated because of remote-theme users.

Perhaps it's time to fork and have a less-mistakes repo that expects a proper Jekyll and GitHub Action deployment, but keeps up with upstream changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants