Skip to content

Feature request: Support for BUTTON events in Eyelink ASC file parser #13250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WouterKroot opened this issue May 16, 2025 · 3 comments
Open
Labels

Comments

@WouterKroot
Copy link

Describe the new feature or enhancement

I’m currently using read_raw_eyelink() to load Eyelink ASC files, but I noticed that BUTTON events in the ASC files are not captured or annotated.

I checked the code and it seems BUTTON events aren’t supported yet.

Is there any plan to support BUTTON events? Or is there a recommended workaround to include BUTTON events as annotations?

Thanks a lot for the help and the great package!

Describe your proposed implementation

In the create_annotations in mne/io/eyelink/_utils.py add 'BUTTON' to handle:

raw = read_raw_eyelink(path, create_annotations=['blinks', 'messages', 'buttons'])

Describe possible alternatives

manually parse

Additional context

No response

@larsoner
Copy link
Member

@WouterKroot would you be up for adding support for BUTTON events? And maybe the default create_annotations=True should include these events (would count as an enhancement I think). cc @scott-huberty

@WouterKroot
Copy link
Author

Sure, I'll first look at the contribution guide.

@WouterKroot
Copy link
Author

I sent in a pull request #13253, feel free to contact me if any further changes are necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants