feat: make compatiable with old version mobx (#84)

* feat: make compatiable with old version mobx * chore: change readme
mobxjs · Jan 7, 2022 · 5ee8734 · 5ee8734
1 parent 8d4da71
commit 5ee8734
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -12,7 +12,7 @@ Vue2 bindings for MobX, inspired by [mobx-react](https://github.com/mobxjs/mobx-
 ## Support Table
 | package | mobx v6 | mobx v2/v3/v4/v5 | vue2 | vue3 | 
 | ------  | ------- | ---------------- | ---- | ---- |
-| [mobx-vue](https://github.com/mobxjs/mobx-vue) | >= 2.1.0 | < 2.1.0 | * | - |
+| [mobx-vue](https://github.com/mobxjs/mobx-vue) | >= v2.1.0 | * (exclude v2.1.0) | * | - |
 | [mobx-vue-lite](https://github.com/mobxjs/mobx-vue-lite) | * | - | - | * |
 > `*` means `all` and `-` means `none`
  
@@ -28,10 +28,6 @@ or
 yarn add mobx-vue
 ```
 
-## Requirement
-* Vue >= 2.0.0
-* MobX >= 2.0.0, compatible with MobX 5!
-
 ## Why mobx-vue 
 
 MobX is an unopinionated, scalable state management, which can make our programming more intuitive.

diff --git a/package.json b/package.json
@@ -33,7 +33,7 @@
   },
   "homepage": "https://github.com/mobxjs/mobx-vue#readme",
   "peerDependencies": {
-    "mobx": "^6.0.0",
+    "mobx": "^2.0.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0",
     "vue": "^2.0.0"
   },
   "devDependencies": {

diff --git a/src/observer.ts b/src/observer.ts
@@ -65,7 +65,8 @@ function observer<VC extends VueClass<Vue>>(Component: VC | ComponentOptions<Vue
 
 		const reaction = new Reaction(`${name}.render()`, reactiveRender);
 
-		this[disposerSymbol] = reaction.getDisposer_();
+		// @ts-expect-error
+		this[disposerSymbol] = reaction.getDisposer_?.() || reaction.getDisposer?.();
 
 		return reactiveRender();
 	};