fix: error with code generation when file has unnamed extension (#1020)

* fix: error with code generation when file has unnamed extension

* fix: error with code generation when file has unnamed extension

Author: amondnet

mobx_codegen/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.6.2
+
+- Fixes [error with code generation when file has unnamed extension](https://github.com/mobxjs/mobx.dart/issues/1010) by [@amondnet](https://github.com/amondnet) in [#1020](https://github.com/mobxjs/mobx.dart/pull/1020)
+
 ## 2.6.1+1
 
 - Fixing some analyzer errors related to deprecated types.

mobx_codegen/lib/src/template/method_override.dart

@@ -43,7 +43,7 @@ class MethodOverrideTemplate {
 
   late String name;
   late String returnType;
-  late SurroundedCommaList<String> returnTypeArgs;
+  late SurroundedCommaList<String?> returnTypeArgs;
 
   late SurroundedCommaList<TypeParamTemplate> _typeParams;
   late SurroundedCommaList<String> _typeArgs;

mobx_codegen/lib/src/type_names.dart

@@ -22,14 +22,14 @@ class LibraryScopedNameFinder {
 
   final LibraryElement library;
 
-  final Map<Element, String> _namesByElement = {};
+  final Map<Element, String?> _namesByElement = {};
 
-  Map<Element, String> get namesByElement {
+  Map<Element, String?> get namesByElement {
     // Add all of this library's type-defining elements to the name map
     final libraryElements =
         library.topLevelElements.whereType<TypeDefiningElement>();
     for (final element in libraryElements) {
-      _namesByElement[element] = element.name!;
+      _namesByElement[element] = element.name;
     }
 
     // Reverse each import's export namespace so we can map elements to their
@@ -59,14 +59,14 @@ class LibraryScopedNameFinder {
   String findReturnTypeName(FunctionTypedElement executable) =>
       _getDartTypeName(executable.returnType);
 
-  List<String> findReturnTypeArgumentTypeNames(ExecutableElement executable) {
+  List<String?> findReturnTypeArgumentTypeNames(ExecutableElement executable) {
     final returnType = executable.returnType;
     return returnType is ParameterizedType
         ? returnType.typeArguments.map(_getDartTypeName).toList()
         : [];
   }
 
-  String findTypeParameterBoundsTypeName(TypeParameterElement typeParameter) {
+  String? findTypeParameterBoundsTypeName(TypeParameterElement typeParameter) {
     assert(typeParameter.bound != null);
     return _getDartTypeName(typeParameter.bound!);
   }

mobx_codegen/lib/version.dart

@@ -1,4 +1,4 @@
 // Generated via set_version.dart. !!!DO NOT MODIFY BY HAND!!!
 
 /// The current version as per `pubspec.yaml`.
-const version = '2.6.1+1';
+const version = '2.6.2';

mobx_codegen/pubspec.yaml

@@ -1,6 +1,6 @@
 name: mobx_codegen
 description: Code generator for MobX that adds support for annotating your code with @observable, @computed, @action and also creating Store classes.
-version: 2.6.1+1
+version: 2.6.2
 
 repository: https://github.com/mobxjs/mobx.dart
 issue_tracker: https://github.com/mobxjs/mobx.dart/issues

mobx_codegen/test/data/with_extension_input.dart

@@ -0,0 +1,15 @@
+library generator_sample;
+
+import 'package:mobx/mobx.dart';
+
+part 'generator_sample.g.dart';
+
+// ignore: library_private_types_in_public_api
+class Foo = _Foo with _$Foo;
+
+abstract class _Foo with Store {
+  @observable
+  late String name;
+}
+
+extension on int {}

mobx_codegen/test/data/with_extension_output.dart

@@ -59,6 +59,11 @@ void main() {
           './data/valid_keep_alive_computed_output.dart');
     });
 
+    test('generates for a class with extension', () async {
+      await compareFiles('./data/with_extension_input.dart',
+          './data/with_extension_output.dart');
+    });
+
     createTests([
       const TestInfo(
           description: 'invalid output is handled',