fix: stacktrace in computed #988
Conversation
❌ Deploy Preview for mobx failed.
|
mobx/test/exceptions_test.dart
Outdated
| test('should preserve stacktrace', () async { | ||
| final stackTrace = StackTrace.current; | ||
| try { | ||
| Computed(() => Error.throwWithStackTrace(Exception('test'), stackTrace)) |
There was a problem hiding this comment.
Can we add a test with a simple exception instead of using Error.throwWithStackTrace ? Not all code will use this technique. We should see if the stacktrace is picked up automatically from deeper exceptions in code
| @@ -91,7 +91,7 @@ class ReactionImpl with DebugCreationStack implements Reaction { | |||
| } | |||
There was a problem hiding this comment.
Also need to bump up version and add a changelog for this
altynbek132
force-pushed
the
pr_fix_stacktrace
branch
from
66575b6 to
b4c9e9e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 57 57
Lines 2024 2025 +1
=======================================
+ Hits 2004 2005 +1
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
altynbek132
force-pushed
the
pr_fix_stacktrace
branch
from
fecd79c to
e431554
Compare
| @@ -1,5 +1,5 @@ | |||
| name: mobx | |||
| version: 2.3.0+1 | |||
There was a problem hiding this comment.
The set_version command needs to be called from melos to also change the version.dart file for the package
There was a problem hiding this comment.
More details in this doc: https://mobx.netlify.app/development/release
There was a problem hiding this comment.
formatting is in other pr, because there are several files being changed that are not related to current pr
…eserving stacktrace in Computed and Reaction functions
altynbek132
force-pushed
the
pr_fix_stacktrace
branch
from
6515e76 to
0d2acde
Compare
when error is thrown in computed stacktrace should not be lost (check tests)
we have to use Error.throwWithStackTrace