testutil: copy slim version of the docker client into testutil #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dependencies
jsternberg
force-pushed
the
remove-docker-api-dependency
branch
2 times, most recently
from
723c3dc to
85a8590
Compare
thaJeztah
reviewed
Feb 12, 2025
jsternberg
force-pushed
the
remove-docker-api-dependency
branch
from
85a8590 to
2d26d6c
Compare
|
@jsternberg Can you open a draft PR from this branch in moby so we can see the tests with |
jsternberg
force-pushed
the
remove-docker-api-dependency
branch
from
2d26d6c to
35d84a6
Compare
|
This is passing in the draft PR. I had to rebase this PR to be based on v0.19 though to make it work because of unrelated API changes. I'll rebase it back and resolve the conflicts. |
jsternberg
force-pushed
the
remove-docker-api-dependency
branch
from
35d84a6 to
2cea406
Compare
Copies a slim version of the docker client with only the necessary methods so we can break our dependency on the client in moby. This client is only used in an integration test so it's not really needed and we don't really actively need updates or to be on the most recent API version since we just do an unversioned ping and then call the hijack method. This was created by copying the package into `testutil` and then deleting unused sections of code. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
remove-docker-api-dependency
branch
from
2cea406 to
f81eeb4
Compare
crazy-max
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies a slim version of the docker client with only the necessary methods so we can break our dependency on the client in moby. This client is only used in an integration test so it's not really needed and we don't really actively need updates or to be on the most recent API version since we just do an unversioned ping and then call the hijack method.
This was created by copying the package into
testutiland then deleting unused sections of code.Fixes #3355.