Remove isize overflow check for zst offsets #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynzech
force-pushed
the
offset-zsts
branch
from
05e0599 to
f648179
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
## What's Changed * Automatic cargo update to 2025-02-10 by @github-actions in #3880 * Bump tests/perf/s2n-quic from `82dd0b5` to `a5d8422` by @dependabot in #3882 * Fast fail feature - Stops verification process as soon as one failure is observed - Use case : CI speed up by @rajath-mk in #3879 * Autoharness Subcommand by @carolynzech in #3874 * Upgrade toolchain to 2/10 by @carolynzech in #3883 * Add loop-contracts doc to SUMMARY by @qinheping in #3886 * Support concrete playback for arrays of length 65 or greater by @carolynzech in #3888 * Automatic cargo update to 2025-02-17 by @github-actions in #3889 * Bump tests/perf/s2n-quic from `a5d8422` to `00e3371` by @dependabot in #3894 * Adjust PropertyClass of assertions to identify UB by @tautschnig in #3860 * Fix: regression test from #3888 has version control change by @carolynzech in #3892 * Upgrade toolchain to 2025-02-11 by @thanhnguyen-aws in #3887 * Remove isize overflow check for zst offsets by @carolynzech in #3897 * Automatic toolchain upgrade to nightly-2025-02-12 by @github-actions in #3898 * Upgrade the toolchain to 2025-02-21 by @zhassan-aws in #3899 * Automatic cargo update to 2025-02-24 by @github-actions in #3901 * Bump ncipollo/release-action from 1.15.0 to 1.16.0 by @dependabot in #3902 * Bump tests/perf/s2n-quic from `00e3371` to `cfb314b` by @dependabot in #3903 * Convert raw URL to link by @flba-eb in #3907 * Automatic cargo update to 2025-03-03 by @github-actions in #3913 * Install toolchain with rustup >= 1.28.0 by @tautschnig in #3917 * Bump tests/perf/s2n-quic from `cfb314b` to `d88faa4` by @dependabot in #3916 * Remove Ubuntu 20.04 CI usage by @tautschnig in #3918 * Move standard-library metrics script to verify-rust-std repo by @tautschnig in #3914 * scanner: Fix loop stats in overall function stats summary by @tautschnig in #3915 * Update toolchain to 2025-03-02 by @remi-delmas-3000 in #3911 ## New Contributors * @flba-eb made their first contribution in #3907 **Full Changelog**: kani-0.59.0...kani-0.60.0 --------- Co-authored-by: Carolyn Zech <cmzech@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3755 introduced additional safety checks for the
offsetintrinsic, including a check for whethercountoverflowsisize. However, such overflow is allowed for ZSTs. This PR changes the model to check for ZSTs before computing the offset to avoid triggering an overflow failure for ZSTs.I also moved an existing test called
offset-overflowinto another test, since #3755 changed the failure for that test to be about an out of bounds allocation, not an isize overflow.Resolves #3896
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.