From d0a9b86725743689ee8296b37d1e19f15a0c5180 Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Thu, 31 Oct 2024 22:15:33 -0400 Subject: [PATCH 1/9] kani list workflow --- .github/workflows/list.yml | 33 ++++++++++++++ library/Cargo.lock | 88 ++++++++++++++++++++++++++++++++++++++ scripts/run-kani.sh | 38 ++++++++++++---- 3 files changed, 150 insertions(+), 9 deletions(-) create mode 100644 .github/workflows/list.yml diff --git a/.github/workflows/list.yml b/.github/workflows/list.yml new file mode 100644 index 0000000000000..acebaa99e8b2f --- /dev/null +++ b/.github/workflows/list.yml @@ -0,0 +1,33 @@ +name: Kani List + +on: + workflow_dispatch: + pull_request: + branches: [ main ] + types: [ closed ] + +defaults: + run: + shell: bash + +jobs: + run-kani-list-on-std: + name: List Kani harnesses and contracts on std library + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest] + include: + - os: ubuntu-latest + base: ubuntu + steps: + # Step 1: Check out the repository + - name: Checkout Repository + uses: actions/checkout@v4 + with: + path: head + submodules: true + + # Step 2: Run list on the std library (default configuration) + - name: Run Kani Verification + run: head/scripts/run-kani.sh --run list --path ${{github.workspace}}/head diff --git a/library/Cargo.lock b/library/Cargo.lock index 54ad052c52322..713ae2c9032fb 100644 --- a/library/Cargo.lock +++ b/library/Cargo.lock @@ -32,6 +32,7 @@ dependencies = [ "core", "rand", "rand_xorshift", + "safety", ] [[package]] @@ -72,6 +73,7 @@ version = "0.0.0" dependencies = [ "rand", "rand_xorshift", + "safety", ] [[package]] @@ -219,6 +221,39 @@ dependencies = [ "unwind", ] +[[package]] +name = "proc-macro-error" +version = "1.0.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "da25490ff9892aab3fcf7c36f08cfb902dd3e71ca0f9f9517bea02a73a5ce38c" +dependencies = [ + "proc-macro-error-attr", + "proc-macro2", + "quote", + "syn 1.0.109", + "version_check", +] + +[[package]] +name = "proc-macro-error-attr" +version = "1.0.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "a1be40180e52ecc98ad80b184934baf3d0d29f979574e439af5a55274b35f869" +dependencies = [ + "proc-macro2", + "quote", + "version_check", +] + +[[package]] +name = "proc-macro2" +version = "1.0.89" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "f139b0662de085916d1fb67d2b4169d1addddda1919e696f3252b740b629986e" +dependencies = [ + "unicode-ident", +] + [[package]] name = "proc_macro" version = "0.0.0" @@ -236,6 +271,15 @@ dependencies = [ "core", ] +[[package]] +name = "quote" +version = "1.0.37" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "b5b9d34b8991d19d98081b46eacdd8eb58c6f2b201139f7c5f643cc155a633af" +dependencies = [ + "proc-macro2", +] + [[package]] name = "r-efi" version = "4.5.0" @@ -312,6 +356,16 @@ dependencies = [ "std", ] +[[package]] +name = "safety" +version = "0.1.0" +dependencies = [ + "proc-macro-error", + "proc-macro2", + "quote", + "syn 2.0.86", +] + [[package]] name = "std" version = "0.0.0" @@ -336,6 +390,7 @@ dependencies = [ "rand", "rand_xorshift", "rustc-demangle", + "safety", "std_detect", "unwind", "wasi", @@ -353,6 +408,27 @@ dependencies = [ "rustc-std-workspace-core", ] +[[package]] +name = "syn" +version = "1.0.109" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "72b64191b275b66ffe2469e8af2c1cfe3bafa67b529ead792a6d0160888b4237" +dependencies = [ + "proc-macro2", + "unicode-ident", +] + +[[package]] +name = "syn" +version = "2.0.86" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "e89275301d38033efb81a6e60e3497e734dfcc62571f2854bf4b16690398824c" +dependencies = [ + "proc-macro2", + "quote", + "unicode-ident", +] + [[package]] name = "sysroot" version = "0.0.0" @@ -372,6 +448,12 @@ dependencies = [ "std", ] +[[package]] +name = "unicode-ident" +version = "1.0.13" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "e91b56cd4cadaeb79bbf1a5645f6b4f8dc5bde8834ad5894a8db35fda9efa1fe" + [[package]] name = "unicode-width" version = "0.1.13" @@ -405,6 +487,12 @@ dependencies = [ "rustc-std-workspace-core", ] +[[package]] +name = "version_check" +version = "0.9.5" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "0b928f33d975fc6ad9f86c8f283853ad26bdd5b10b7f1542aa2fa15e2289105a" + [[package]] name = "wasi" version = "0.11.0+wasi-snapshot-preview1" diff --git a/scripts/run-kani.sh b/scripts/run-kani.sh index 8ce27dac5d207..30fdb2be33f81 100755 --- a/scripts/run-kani.sh +++ b/scripts/run-kani.sh @@ -3,10 +3,11 @@ set -e usage() { - echo "Usage: $0 [options] [-p ] [--kani-args ]" + echo "Usage: $0 [options] [-p ] [--run ] [--kani-args ]" echo "Options:" echo " -h, --help Show this help message" echo " -p, --path Optional: Specify a path to a copy of the std library. For example, if you want to run the script from an outside directory." + echo " --run Optional: Specify whether to run 'verify-std' or 'list' command. Defaults to 'verify-std' if not specified." echo " --kani-args Optional: Arguments to pass to the command. Simply pass them in the same way you would to the Kani binary. This should be the last argument." exit 1 } @@ -14,9 +15,9 @@ usage() { # Initialize variables command_args="" path="" +run_command="verify-std" # Default value # Parse command line arguments -# TODO: Improve parsing with getopts while [[ $# -gt 0 ]]; do case $1 in -h|--help) @@ -31,13 +32,28 @@ while [[ $# -gt 0 ]]; do usage fi ;; + --run) + if [[ -n $2 && ($2 == "verify-std" || $2 == "list") ]]; then + run_command=$2 + shift 2 + else + echo "Error: Invalid run command. Must be 'verify-std' or 'list'." + usage + fi + ;; --kani-args) - shift - command_args="$@" - break + if [[ $# -gt 1 ]]; then + shift + command_args="$@" + break + else + echo "Error: --kani-args requires additional arguments" + usage + fi ;; *) - break + echo "Error: Unknown option $1" + usage ;; esac done @@ -181,9 +197,13 @@ main() { echo "Running Kani command..." "$kani_path" --version - echo "Running Kani verify-std command..." - - "$kani_path" verify-std -Z unstable-options ./library --target-dir "$temp_dir_target" -Z function-contracts -Z mem-predicates --output-format=terse $command_args + if [[ "$run_command" == "verify-std" ]]; then + echo "Running Kani verify-std command..." + "$kani_path" verify-std -Z unstable-options ./library --target-dir "$temp_dir_target" -Z function-contracts -Z mem-predicates --output-format=terse $command_args + elif [[ "$run_command" == "list" ]]; then + echo "Running Kani list command..." + "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std + fi } main From 6785f7c30986071b3b5e9817a957328d47e0e2a3 Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Thu, 31 Oct 2024 22:21:33 -0400 Subject: [PATCH 2/9] publish comment with list results --- .github/workflows/list.yml | 25 ++++++++++++++++++++++--- scripts/run-kani.sh | 2 +- 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/.github/workflows/list.yml b/.github/workflows/list.yml index acebaa99e8b2f..4a9d171f1e32a 100644 --- a/.github/workflows/list.yml +++ b/.github/workflows/list.yml @@ -28,6 +28,25 @@ jobs: path: head submodules: true - # Step 2: Run list on the std library (default configuration) - - name: Run Kani Verification - run: head/scripts/run-kani.sh --run list --path ${{github.workspace}}/head + # Step 2: Run list on the std library and capture output + - name: Run Kani List + id: kani-list + run: | + output=$(head/scripts/run-kani.sh --run list --path ${{github.workspace}}/head) + echo "KANI_OUTPUT<> $GITHUB_ENV + echo "$output" >> $GITHUB_ENV + echo "EOF" >> $GITHUB_ENV + + # Step 3: Comment on the PR with the Kani list output + - name: Comment PR + uses: actions/github-script@v6 + if: github.event.pull_request.merged == true + with: + github-token: ${{secrets.GITHUB_TOKEN}} + script: | + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.name, + body: 'Kani List Results:\n```\n' + process.env.KANI_OUTPUT + '\n```' + }) \ No newline at end of file diff --git a/scripts/run-kani.sh b/scripts/run-kani.sh index 30fdb2be33f81..cd5f3c9d806df 100755 --- a/scripts/run-kani.sh +++ b/scripts/run-kani.sh @@ -202,7 +202,7 @@ main() { "$kani_path" verify-std -Z unstable-options ./library --target-dir "$temp_dir_target" -Z function-contracts -Z mem-predicates --output-format=terse $command_args elif [[ "$run_command" == "list" ]]; then echo "Running Kani list command..." - "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std + echo "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std fi } From 3e1b2f1cb1892c0d6b70ecf1d45ccbe822d9931e Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Thu, 31 Oct 2024 22:48:32 -0400 Subject: [PATCH 3/9] remove echo --- scripts/run-kani.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/run-kani.sh b/scripts/run-kani.sh index cd5f3c9d806df..30fdb2be33f81 100755 --- a/scripts/run-kani.sh +++ b/scripts/run-kani.sh @@ -202,7 +202,7 @@ main() { "$kani_path" verify-std -Z unstable-options ./library --target-dir "$temp_dir_target" -Z function-contracts -Z mem-predicates --output-format=terse $command_args elif [[ "$run_command" == "list" ]]; then echo "Running Kani list command..." - echo "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std + "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std fi } From ae6f58722cbf3ba90d754b9fe2aedb5ee9aeab2a Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Thu, 31 Oct 2024 22:57:36 -0400 Subject: [PATCH 4/9] try fixing comment pr permissions issue --- .github/workflows/list.yml | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/.github/workflows/list.yml b/.github/workflows/list.yml index 4a9d171f1e32a..675d6003a8aff 100644 --- a/.github/workflows/list.yml +++ b/.github/workflows/list.yml @@ -6,6 +6,9 @@ on: branches: [ main ] types: [ closed ] +permissions: + pull-requests: write + defaults: run: shell: bash @@ -14,6 +17,8 @@ jobs: run-kani-list-on-std: name: List Kani harnesses and contracts on std library runs-on: ${{ matrix.os }} + # Only run this job if the pull request was merged + if: github.event.pull_request.merged == true strategy: matrix: os: [ubuntu-latest] @@ -37,16 +42,26 @@ jobs: echo "$output" >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV - # Step 3: Comment on the PR with the Kani list output + # Step 3: Debug Info + - name: Debug Info + run: | + echo "Owner: ${{ github.repository_owner }}" + echo "Repo: ${{ github.repository }}" + echo "PR Number: ${{ github.event.pull_request.number }}" + + # Step 4: Post comment on PR with Kani list results - name: Comment PR uses: actions/github-script@v6 - if: github.event.pull_request.merged == true with: github-token: ${{secrets.GITHUB_TOKEN}} script: | + console.log('Owner:', context.repo.owner); + console.log('Repo:', context.repo.repo); + console.log('Issue Number:', context.issue.number); + github.rest.issues.createComment({ - issue_number: context.issue.number, + issue_number: ${{ github.event.pull_request.number }}, owner: context.repo.owner, - repo: context.repo.name, + repo: context.repo.repo, body: 'Kani List Results:\n```\n' + process.env.KANI_OUTPUT + '\n```' }) \ No newline at end of file From 3c0b99d0592685a6256531eaf56946853ed471d2 Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Thu, 31 Oct 2024 23:21:36 -0400 Subject: [PATCH 5/9] try to only post the table in the comment --- .github/workflows/list.yml | 34 +++++++++++++--------------------- scripts/run-kani.sh | 2 +- 2 files changed, 14 insertions(+), 22 deletions(-) diff --git a/.github/workflows/list.yml b/.github/workflows/list.yml index 675d6003a8aff..dd47129a1807f 100644 --- a/.github/workflows/list.yml +++ b/.github/workflows/list.yml @@ -33,35 +33,27 @@ jobs: path: head submodules: true - # Step 2: Run list on the std library and capture output + # Step 2: Run list on the std library (assumes it creates kani-list.txt) - name: Run Kani List - id: kani-list - run: | - output=$(head/scripts/run-kani.sh --run list --path ${{github.workspace}}/head) - echo "KANI_OUTPUT<> $GITHUB_ENV - echo "$output" >> $GITHUB_ENV - echo "EOF" >> $GITHUB_ENV + run: head/scripts/run-kani.sh --run list --path ${{github.workspace}}/head - # Step 3: Debug Info - - name: Debug Info - run: | - echo "Owner: ${{ github.repository_owner }}" - echo "Repo: ${{ github.repository }}" - echo "PR Number: ${{ github.event.pull_request.number }}" - - # Step 4: Post comment on PR with Kani list results + # Step 3: Read kani-list.txt and post comment on PR - name: Comment PR uses: actions/github-script@v6 with: github-token: ${{secrets.GITHUB_TOKEN}} script: | - console.log('Owner:', context.repo.owner); - console.log('Repo:', context.repo.repo); - console.log('Issue Number:', context.issue.number); + const fs = require('fs'); + const kaniOutput = fs.readFileSync('kani_list.txt', 'utf8'); - github.rest.issues.createComment({ + await github.rest.issues.createComment({ issue_number: ${{ github.event.pull_request.number }}, owner: context.repo.owner, repo: context.repo.repo, - body: 'Kani List Results:\n```\n' + process.env.KANI_OUTPUT + '\n```' - }) \ No newline at end of file + body: 'Kani List Results:\n```\n' + kaniOutput + '\n```' + }); + + # Step 4: Cleanup + - name: Cleanup + if: always() + run: rm -f kani_list.txt \ No newline at end of file diff --git a/scripts/run-kani.sh b/scripts/run-kani.sh index 30fdb2be33f81..2522070f75754 100755 --- a/scripts/run-kani.sh +++ b/scripts/run-kani.sh @@ -202,7 +202,7 @@ main() { "$kani_path" verify-std -Z unstable-options ./library --target-dir "$temp_dir_target" -Z function-contracts -Z mem-predicates --output-format=terse $command_args elif [[ "$run_command" == "list" ]]; then echo "Running Kani list command..." - "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std + "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std > kani_list.txt fi } From 38a6486b85e72b4df380aef2af3b67362906eadb Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Thu, 31 Oct 2024 23:30:10 -0400 Subject: [PATCH 6/9] attempt to fix ENOENT --- .github/workflows/list.yml | 7 +------ scripts/run-kani.sh | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/list.yml b/.github/workflows/list.yml index dd47129a1807f..517a10bc75bef 100644 --- a/.github/workflows/list.yml +++ b/.github/workflows/list.yml @@ -44,7 +44,7 @@ jobs: github-token: ${{secrets.GITHUB_TOKEN}} script: | const fs = require('fs'); - const kaniOutput = fs.readFileSync('kani_list.txt', 'utf8'); + const kaniOutput = fs.readFileSync('${{github.workspace}}/head/kani_list.txt', 'utf8'); await github.rest.issues.createComment({ issue_number: ${{ github.event.pull_request.number }}, @@ -52,8 +52,3 @@ jobs: repo: context.repo.repo, body: 'Kani List Results:\n```\n' + kaniOutput + '\n```' }); - - # Step 4: Cleanup - - name: Cleanup - if: always() - run: rm -f kani_list.txt \ No newline at end of file diff --git a/scripts/run-kani.sh b/scripts/run-kani.sh index 2522070f75754..b3598d0742518 100755 --- a/scripts/run-kani.sh +++ b/scripts/run-kani.sh @@ -202,7 +202,7 @@ main() { "$kani_path" verify-std -Z unstable-options ./library --target-dir "$temp_dir_target" -Z function-contracts -Z mem-predicates --output-format=terse $command_args elif [[ "$run_command" == "list" ]]; then echo "Running Kani list command..." - "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std > kani_list.txt + "$kani_path" list -Z list -Z function-contracts -Z mem-predicates ./library --std > $path/kani_list.txt fi } From 561c6b4b8502d997f017176edd5826d8596b9c95 Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Thu, 31 Oct 2024 23:45:09 -0400 Subject: [PATCH 7/9] undo unnecessary changes --- library/Cargo.lock | 90 +-------------------------------------------- scripts/run-kani.sh | 14 +++---- 2 files changed, 6 insertions(+), 98 deletions(-) diff --git a/library/Cargo.lock b/library/Cargo.lock index 713ae2c9032fb..c899a2eb32bd2 100644 --- a/library/Cargo.lock +++ b/library/Cargo.lock @@ -32,7 +32,6 @@ dependencies = [ "core", "rand", "rand_xorshift", - "safety", ] [[package]] @@ -73,7 +72,6 @@ version = "0.0.0" dependencies = [ "rand", "rand_xorshift", - "safety", ] [[package]] @@ -221,39 +219,6 @@ dependencies = [ "unwind", ] -[[package]] -name = "proc-macro-error" -version = "1.0.4" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "da25490ff9892aab3fcf7c36f08cfb902dd3e71ca0f9f9517bea02a73a5ce38c" -dependencies = [ - "proc-macro-error-attr", - "proc-macro2", - "quote", - "syn 1.0.109", - "version_check", -] - -[[package]] -name = "proc-macro-error-attr" -version = "1.0.4" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "a1be40180e52ecc98ad80b184934baf3d0d29f979574e439af5a55274b35f869" -dependencies = [ - "proc-macro2", - "quote", - "version_check", -] - -[[package]] -name = "proc-macro2" -version = "1.0.89" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f139b0662de085916d1fb67d2b4169d1addddda1919e696f3252b740b629986e" -dependencies = [ - "unicode-ident", -] - [[package]] name = "proc_macro" version = "0.0.0" @@ -271,15 +236,6 @@ dependencies = [ "core", ] -[[package]] -name = "quote" -version = "1.0.37" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "b5b9d34b8991d19d98081b46eacdd8eb58c6f2b201139f7c5f643cc155a633af" -dependencies = [ - "proc-macro2", -] - [[package]] name = "r-efi" version = "4.5.0" @@ -356,16 +312,6 @@ dependencies = [ "std", ] -[[package]] -name = "safety" -version = "0.1.0" -dependencies = [ - "proc-macro-error", - "proc-macro2", - "quote", - "syn 2.0.86", -] - [[package]] name = "std" version = "0.0.0" @@ -390,7 +336,6 @@ dependencies = [ "rand", "rand_xorshift", "rustc-demangle", - "safety", "std_detect", "unwind", "wasi", @@ -408,27 +353,6 @@ dependencies = [ "rustc-std-workspace-core", ] -[[package]] -name = "syn" -version = "1.0.109" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "72b64191b275b66ffe2469e8af2c1cfe3bafa67b529ead792a6d0160888b4237" -dependencies = [ - "proc-macro2", - "unicode-ident", -] - -[[package]] -name = "syn" -version = "2.0.86" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e89275301d38033efb81a6e60e3497e734dfcc62571f2854bf4b16690398824c" -dependencies = [ - "proc-macro2", - "quote", - "unicode-ident", -] - [[package]] name = "sysroot" version = "0.0.0" @@ -448,12 +372,6 @@ dependencies = [ "std", ] -[[package]] -name = "unicode-ident" -version = "1.0.13" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e91b56cd4cadaeb79bbf1a5645f6b4f8dc5bde8834ad5894a8db35fda9efa1fe" - [[package]] name = "unicode-width" version = "0.1.13" @@ -487,12 +405,6 @@ dependencies = [ "rustc-std-workspace-core", ] -[[package]] -name = "version_check" -version = "0.9.5" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "0b928f33d975fc6ad9f86c8f283853ad26bdd5b10b7f1542aa2fa15e2289105a" - [[package]] name = "wasi" version = "0.11.0+wasi-snapshot-preview1" @@ -579,4 +491,4 @@ checksum = "852298e482cd67c356ddd9570386e2862b5673c85bd5f88df9ab6802b334c596" name = "windows_x86_64_msvc" version = "0.52.5" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "bec47e5bfd1bff0eeaf6d8b485cc1074891a197ab4225d504cb7a1ab88b02bf0" +checksum = "bec47e5bfd1bff0eeaf6d8b485cc1074891a197ab4225d504cb7a1ab88b02bf0" \ No newline at end of file diff --git a/scripts/run-kani.sh b/scripts/run-kani.sh index b3598d0742518..a4f6b46a825bb 100755 --- a/scripts/run-kani.sh +++ b/scripts/run-kani.sh @@ -15,9 +15,10 @@ usage() { # Initialize variables command_args="" path="" -run_command="verify-std" # Default value +run_command="verify-std" # Parse command line arguments +# TODO: Improve parsing with getopts while [[ $# -gt 0 ]]; do case $1 in -h|--help) @@ -42,14 +43,9 @@ while [[ $# -gt 0 ]]; do fi ;; --kani-args) - if [[ $# -gt 1 ]]; then - shift - command_args="$@" - break - else - echo "Error: --kani-args requires additional arguments" - usage - fi + shift + command_args="$@" + break ;; *) echo "Error: Unknown option $1" From 2f02fa4867d81ccd5da83bebdd7acecafbdd4d01 Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Thu, 31 Oct 2024 23:47:42 -0400 Subject: [PATCH 8/9] newline --- library/Cargo.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/Cargo.lock b/library/Cargo.lock index c899a2eb32bd2..54ad052c52322 100644 --- a/library/Cargo.lock +++ b/library/Cargo.lock @@ -491,4 +491,4 @@ checksum = "852298e482cd67c356ddd9570386e2862b5673c85bd5f88df9ab6802b334c596" name = "windows_x86_64_msvc" version = "0.52.5" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "bec47e5bfd1bff0eeaf6d8b485cc1074891a197ab4225d504cb7a1ab88b02bf0" \ No newline at end of file +checksum = "bec47e5bfd1bff0eeaf6d8b485cc1074891a197ab4225d504cb7a1ab88b02bf0" From f77a66277b1029350830c18e0cf58299d2c1d132 Mon Sep 17 00:00:00 2001 From: Carolyn Zech Date: Fri, 1 Nov 2024 08:45:12 -0400 Subject: [PATCH 9/9] bikesheds --- .github/workflows/list.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/list.yml b/.github/workflows/list.yml index 517a10bc75bef..06ed7ceff0422 100644 --- a/.github/workflows/list.yml +++ b/.github/workflows/list.yml @@ -33,12 +33,12 @@ jobs: path: head submodules: true - # Step 2: Run list on the std library (assumes it creates kani-list.txt) + # Step 2: Run list on the std library (assumes it creates kani_list.txt) - name: Run Kani List run: head/scripts/run-kani.sh --run list --path ${{github.workspace}}/head - # Step 3: Read kani-list.txt and post comment on PR - - name: Comment PR + # Step 3: Read kani_list.txt and post comment on PR + - name: Comment Results on PR uses: actions/github-script@v6 with: github-token: ${{secrets.GITHUB_TOKEN}}