Skip to content

fix: support custom path when use sse server #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Midicon
Copy link

@Midicon Midicon commented Mar 24, 2025

Support custom path when use sse server

Motivation and Context

I think when I use the SSE Server, it should support customizing the prefix path. Example: if sse's url is http://localhost:8000/some/path/to/sse, it should request http://localhost:8000/some/path/to/messages when sending messages

How Has This Been Tested?

I've tested in my application

Breaking Changes

Not necessary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@dsp-ant
Copy link
Member

dsp-ant commented Mar 25, 2025

You should be able to configure this by using message_path

@dsp-ant dsp-ant closed this Mar 25, 2025
@Midicon
Copy link
Author

Midicon commented Mar 28, 2025

@dsp-ant Modifying the message_path will also modify the router of Starlette, which will lead to the error: "Routed paths must start with '/'".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants