PyPI release workflow #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
force-pushed
the
test-release
branch
from
ba4dad3 to
09fa2de
Compare
jspahrsummers
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
I'm not sure I understand the advantage of keeping things in separate workflow files, versus using ifs within one file, but not a big deal.
I also have a minor preference for using GitHub Releases to trigger automation behaviors, versus just tags (which aren't as prominent in the UI), but YMMV.
|
Releases are best I think. Let me see that I can change it. I am just not super fluent with Github best practises |
dsp-ant
force-pushed
the
test-release
branch
from
09fa2de to
753c76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework Github Actions and add PyPI release workflow:
https://github.com/modelcontextprotocol/python-sdk/actions/runs/11787194910/job/32832022351
https://github.com/modelcontextprotocol/python-sdk/actions/runs/11787306038/job/32832342605
After testing against TestPyPI i removed the code to do so.