Handle MCPErrors separately #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dsp-ant
commented
Nov 22, 2024
dsp-ant
commented
- When any handler raises an McpError, we pass it as a response
- Correct comment
nick-merrill
approved these changes
Nov 22, 2024
Comment on lines
+335
to
+336
| # When False, exceptions are returned as messages to the client. | ||
| # When True, exceptions are raised, which will cause the server to shut down |
There was a problem hiding this comment.
🤦 I would love to have Claude linting for this kind of thing. Or I should just learn not to write so many comments 😆
dsp-ant
force-pushed
the
davidsp/error-fixes
branch
from
8c84736 to
5d661a8
Compare
dsp-ant
force-pushed
the
davidsp/error-fixes
branch
from
5d661a8 to
f7e47f3
Compare
jspahrsummers
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.