fix: Pass cursor parameter to server #745
Merged
+306
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarbettini
commented
May 18, 2025
Comment on lines
-82
to
-87
| class PaginatedRequest(Request[RequestParamsT, MethodT]): | ||
| cursor: Cursor | None = None | ||
| """ | ||
| An opaque token representing the current pagination position. | ||
| If provided, the server should return results starting after this cursor. | ||
| """ |
There was a problem hiding this comment.
Removed this, since it was only used for the methods in question.
nbarbettini
commented
May 18, 2025
Comment on lines
+88
to
+90
| @pytest.fixture | ||
| def stream_spy(): | ||
| """Fixture that provides spies for both client and server write streams. |
There was a problem hiding this comment.
Built this as a fixture so that it can be easily reused in multiple tests.
I needed a way to verify the request payload "on the wire" and this seemed like a good approach, since it did not require any modification of the actual client code (only test fixtures).
|
Thanks for the guidance @ihrpr! I've pushed these changes:
|
ihrpr
reviewed
May 21, 2025
There was a problem hiding this comment.
Thank you so much @nbarbettini for the quick turnaround.
I think we can remove params: PaginatedRequestParams | None = None?
|
No problem, happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #735 by:
See also: PR comments inline
I'm happy to update the approach if it doesn't fit the style of this repo.
How Has This Been Tested?
Breaking Changes
None - internal changes only, no client interface changes.
Types of changes
Checklist