Skip to content

Added functionlaity for logging information #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Adesoji1
Copy link

@Adesoji1 Adesoji1 commented Jun 2, 2025

Added enhanced logging function

Motivation and Context

  • Demonstrates client-server interactions with a calculator service
  • Shows proper error handling and service discovery
  • Improves documentation through concrete usage example

How Has This Been Tested?

  • Not yet Tested on ubuntu 22.04
  • Verified all calculator operations (add, multiply, divide)
  • Tested error handling for division by zero
  • Validated service discovery and tool listing
  • Confirmed proper connection handling and cleanup

Breaking Changes

  • No breaking changes
  • Adds new functionality without modifying existing code

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

  • Includes proper synchronization between server and client
  • Implements comprehensive logging
  • Demonstrates chained operations (complex_result)
  • Shows realistic service usage patterns

"time",
] }
tokio = { version = "1", features = ["full"] }
# tokio = { version = "1", features = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete these

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@4t145 i have removed line 19 nd reverted to 20, i don't see any ci error again, kindly check

@4t145
Copy link
Collaborator

4t145 commented Jun 3, 2025

Could you fix the ci errors?

@Adesoji1
Copy link
Author

Adesoji1 commented Jun 3, 2025 via email

@Adesoji1
Copy link
Author

Adesoji1 commented Jun 4, 2025

@4t145 kindly view,

@4t145
Copy link
Collaborator

4t145 commented Jun 4, 2025

CI failed again. Seems like hyper implmented Copy trait for FnService and then introduced a clippy error.

cargo clippy --all-targets --all-features
cargo +nightly fmt --all

@Adesoji1
Copy link
Author

Adesoji1 commented Jun 4, 2025

CI failed again. Seems like hyper implmented Copy trait for FnService and then introduced a clippy error.

cargo clippy --all-targets --all-features
cargo +nightly fmt --all

@4t145 thanks, i will look into this

Adesoji1 added 5 commits June 4, 2025 12:31
Added server startup log with bound address
Cloned service handler for proper connection handling
Improved connection logging with client addresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants