Start clearing up annotation syntax for functions. #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the description to make it a link to the issue #3495 for an easy lookup. |
henrikt-ma
reviewed
Dec 6, 2024
henrikt-ma
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Suggesting minor change that will make this more compatible with #3621.
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
eshmoylova
approved these changes
Dec 16, 2024
henrikt-ma
reviewed
Dec 16, 2024
henrikt-ma
requested changes
Dec 16, 2024
|
Language group: Describe these in text (not as default), and then later revisit all. |
Also provide smarter default for LateInline.
This has now been implemented. @henrikt-ma |
henrikt-ma
reviewed
Feb 5, 2025
henrikt-ma
reviewed
Feb 5, 2025
henrikt-ma
reviewed
Feb 5, 2025
henrikt-ma
requested changes
Feb 5, 2025
henrikt-ma
reviewed
Feb 28, 2025
Comment on lines
+1733
to
+1735
| The default for late inlining is tool-specific. | ||
| In particular, tools may automatically delay inlining in order to take advantage of function annotations for derivatives and inverses. | ||
|
|
There was a problem hiding this comment.
I think this would fit even better before the three rules about identical meaning of annotation combinations.
henrikt-ma
requested changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is intended to work towards close #3495 - but it doesn't handle all of the annotations as some are problematic.
Note that I deliberately added default values in some cases, I believe they are the correct ones.
It might be that we should add more, or view this as enough to close it - and later think about the rest.
The problem with the other ones are:
smoothOrder(normallyConstant=x)=2(I have might have missed some that could be handled.)