Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation progress could be optimzed. (Cmake error during installation) #576

Open
2 tasks done
zhenqincn opened this issue Feb 14, 2025 · 0 comments
Open
2 tasks done
Labels
enhancement New feature or request environment related to third-party dependency, DJ-pypi, DJ-docker, etc.

Comments

@zhenqincn
Copy link
Contributor

Search before continuing 先搜索,再继续

  • I have searched the Data-Juicer issues and found no similar feature requests. 我已经搜索了 Data-Juicer 的 issue 列表但是没有发现类似的功能需求。

Description 描述

When I run the following command to install data-juicer, I encounter a CMake error. This happens on multiple machines.

cd <path_to_data_juicer>
pip install -v -e .

Image

I attempted to diagnose the issue and found that the problem seems to be that the installation of data-juicer depends on samplerate, and the compilation failure of samplerate caused the error. After some experiments, I discovered a solution:

Before installing data-juicer, first install samplerate as follows:

  1. Use the system's built-in CMake tool instead of the one installed via pip.
  2. Refer to !(https://github.com/tuxu/python-samplerate/issues/15)[https://github.com/tuxu/python-samplerate/issues/15], run pip -q install git+https://github.com/tuxu/python-samplerate.git@fix_cmake_dep to install a version of samplerate from another branch.

After that, data-juicer could be successfully installed.

Although this issue may not occur on all devices, considering the potential future impact of this platform, it might be necessary to optimize the installation steps or add some special notes in certain places. If I can find out where to add these notes, I would be happy to open a PR to help improve the documentation.

Use case 使用场景

No response

Additional 额外信息

No response

Are you willing to submit a PR for this feature? 您是否乐意为此功能提交一个 PR?

  • Yes I'd like to help by submitting a PR! 是的!我愿意提供帮助并提交一个PR!
@zhenqincn zhenqincn added the enhancement New feature or request label Feb 14, 2025
@yxdyc yxdyc added the environment related to third-party dependency, DJ-pypi, DJ-docker, etc. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request environment related to third-party dependency, DJ-pypi, DJ-docker, etc.
Projects
None yet
Development

No branches or pull requests

2 participants