Improve error when Modrinth's PayPal account is out of funds (#3718)

triphora · web-flow · commit b66d99c59cfe · 2025-05-30T16:28:00.000Z
* Improve error when Modrinth's PayPal account is out of funds

* improve msg
diff --git a/apps/labrinth/src/queue/payouts.rs b/apps/labrinth/src/queue/payouts.rs
@@ -193,9 +193,12 @@ impl PayoutsQueue {
                 pub error_description: String,
             }
 
-            if let Ok(error) =
+            if let Ok(mut error) =
                 serde_json::from_value::<PayPalError>(value.clone())
             {
+                if error.name == "INSUFFICIENT_FUNDS" {
+                    error.message = "We're currently transferring funds to our PayPal account. Please try again in a couple days.".to_string();
+                }
                 return Err(ApiError::Payments(format!(
                     "error name: {}, message: {}",
                     error.name, error.message

Original file line number	Diff line number	Diff line change
`@@ -193,9 +193,12 @@ impl PayoutsQueue {`
`193`	`193`	`pub error_description: String,`
`194`	`194`	`}`
`195`	`195`
`196`		`- if let Ok(error) =`
	`196`	`+ if let Ok(mut error) =`
`197`	`197`	`serde_json::from_value::<PayPalError>(value.clone())`
`198`	`198`	`{`
	`199`	`+ if error.name == "INSUFFICIENT_FUNDS" {`
	`200`	`+ error.message = "We're currently transferring funds to our PayPal account. Please try again in a couple days.".to_string();`
	`201`	`+ }`
`199`	`202`	`return Err(ApiError::Payments(format!(`
`200`	`203`	`"error name: {}, message: {}",`
`201`	`204`	`error.name, error.message`