Skip to content

Migrate blog to knossos #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Migrate blog to knossos #3316

wants to merge 27 commits into from
+3,665 −460

Conversation

Prospector
Copy link
Member

@Prospector Prospector commented Feb 27, 2025 •
edited
Loading

  • the Nuxt Content seems to have an issue with SSR, needs investigation

Erb3
Erb3 suggested changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@Erb3 Erb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to pinpoint where, but this PR seems to break the Discord and X logo in the footer.

image

Screenshot from locally built main:
image

@zefir-git
Copy link
Contributor

zefir-git commented Mar 1, 2025 •
edited
Loading

Discord logo SVG viewBox is removed here: 36160dc

The SVG uses width and height (71x55), but those are then overriden with w-5 h-5 (20x20) which breaks the SVG. Should retain the viewBox and remove the width & height attributes (IMO). Comparison: https://play.tailwindcss.com/GLqCi4pXNl

Irrelevant here, but w-5 h-5 == size-5.

I’d use https://simpleicons.org so that all brand icons have the same viewBox.

@zefir-git
Copy link
Contributor

zefir-git commented Mar 1, 2025 •
edited
Loading

For the X logo, the issue is in the clip path. No idea why a clip path is used. Removing the clip path solves the problem.

Doesn’t look like that’s changed in this PR, though.

@Prospector Prospector marked this pull request as draft March 2, 2025 05:51
@Prospector Prospector requested a review from Geometrically March 2, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erb3 Erb3 Erb3 requested changes

@Geometrically Geometrically Awaiting requested review from Geometrically

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Prospector @zefir-git @Erb3