add user hover cards and ext. link warnings #3443
Open
+1,392
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the command/ctrl+k menu is a fully localizable command menu that opens when a user presses the command/ctrl + k keybind. Screen.Recording.2025-03-30.at.3.10.29.PM.mov |
|
This is awesome, hope this gets merged soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is my first PR, so i probably made a few mistakes. here's what i've done:
add user hover cards to relevant components
these are meant to be as unintrusive as possible and remove when the user scrolls. it takes 150ms for it to start loading the assets required for it on hover of a user-link.
add external link warnings
this checks if the user is visiting a link that is outside of the modrinth scope and gives them a warning if they are.