Skip to content

Finish skins frontend #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 50 commits into
base: skins-frontend
Choose a base branch
from
Draft

Finish skins frontend #3657

wants to merge 50 commits into from
+3,019 −460

Conversation

IMB11
Copy link
Member

@IMB11 IMB11 commented May 15, 2025

No description provided.

IMB11 added 19 commits May 16, 2025 12:53
@AlexTMjugador AlexTMjugador changed the base branch from skins-frontend to main May 16, 2025 10:57
@AlexTMjugador AlexTMjugador changed the base branch from main to skins-frontend May 16, 2025 10:58
@AlexTMjugador
Copy link
Member

Prior work at #3491, #3525 and skins-frontend branch. There is a PR train going on here, so we should either merge the dependent branches in that order, or change the base of this branch to main. Further work on this feature should ideally be pushed to this branch.

@AlexTMjugador AlexTMjugador added enhancement New feature or request app Relates to Modrinth App labels May 16, 2025
IMB11 and others added 27 commits May 18, 2025 01:21
@IMB11
fix: hide error notification when logged out
cb804f7
@IMB11
revert: .gltf formatting
c9b5a24
@AlexTMjugador
chore(app-frontend): fix typos
9e51a2f
@AlexTMjugador
fix(app-lib): delay account skin data deletion to next reboot
44bafea 
This gives users an opportunity to not unexpectedly lose skin data in
case they log off on accident.
@IMB11
fix: login button & provide/inject AccountsCard
9295556
@IMB11
polish: skin buttons
9a4d669
@IMB11
fix: imports
e5ba1be
@IMB11
polish: use figma values
8d58ec0
@IMB11
polish: tweak underneath shadow
6e5ad05
@IMB11
polish: cursor grab
7cc120e
@IMB11
polish: remove green bg from CapeLikeTextButton when selected.
f587338
@IMB11
polish: modal tweaks
1da6b30
@IMB11
polish: grid tweaks + start on upload skin modal
07200f1
@IMB11
polish: drag and drop file flow
30097a2
@IMB11
polish: button positioning in SkinButton
6d90219
@IMB11
fix: lint issues
e0063cb
@IMB11
polish: deduplicate model+cape stuff and fix layout
2acb58f
@IMB11
fix: lint issues
59c8101
@IMB11
fix: camel case requirement for make-default
f9ab581
@IMB11
polish: use indexed db to persist skin previews
627fd09
@IMB11
fix: lint issues
32c935f
@IMB11
polish: add skin icon sizing
e35015c
@IMB11
polish: theme fixes
5fb6835
@IMB11
feat: animation system for skin preview renderer
5b50265
@AlexTMjugador
feat(app/minecraft_skins): save current custom external skin when equ…
7ec2c9e 
…ipping skins
@IMB11
fix: cape button & dynamic nametag sizing
c463f4b
@IMB11
Merge remote-tracking branch 'fork/skins-frontend' into skins-frontend
6696c5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app Relates to Modrinth App enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IMB11 @AlexTMjugador