From 7e5ec586e2fc70e3da782f02cf2b92c20ad6c6cc Mon Sep 17 00:00:00 2001
From: Christoph Hartmann <chris@lollyrock.com>
Date: Wed, 31 Jan 2024 14:50:41 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A4=20reduce=20user=20fetch=20calls=20?=
 =?UTF-8?q?for=20slack=20conversation=20members=20(#3168)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 providers/slack/resources/conversations.go | 27 ++++++++++++++++++----
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/providers/slack/resources/conversations.go b/providers/slack/resources/conversations.go
index 2fd3ee96db..f93bf0552b 100644
--- a/providers/slack/resources/conversations.go
+++ b/providers/slack/resources/conversations.go
@@ -176,6 +176,24 @@ func (s *mqlSlackConversation) members() ([]interface{}, error) {
 		return nil, errors.New("cannot retrieve new data while using a mock connection")
 	}
 
+	// before we fetch the members, we need to fetch all users so that we save the time for individual lookups
+	users, err := CreateResource(s.MqlRuntime, "slack.users", nil)
+	if err != nil {
+		return nil, err
+	}
+	mqlUsers := users.(*mqlSlackUsers)
+	userEntries := mqlUsers.GetList()
+
+	findUser := func(id string) *mqlSlackUser {
+		for i := range userEntries.Data {
+			user := userEntries.Data[i].(*mqlSlackUser)
+			if user.Id.Data == id {
+				return user
+			}
+		}
+		return nil
+	}
+
 	var list []interface{}
 	isChannel := s.IsChannel.Data
 	if !isChannel {
@@ -194,11 +212,10 @@ func (s *mqlSlackConversation) members() ([]interface{}, error) {
 		}
 
 		for i := range members {
-			user, err := NewResource(s.MqlRuntime, "slack.user", map[string]*llx.RawData{
-				"id": llx.StringData(members[i]),
-			})
-			if err != nil {
-				return nil, err
+
+			user := findUser(members[i])
+			if user == nil {
+				return nil, errors.New("could not find user " + members[i])
 			}
 			list = append(list, user)
 		}