Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use count API to make getting microsoft groups count more efficient #5109

Open
vjeffrey opened this issue Jan 21, 2025 · 0 comments · May be fixed by #5153
Open

use count API to make getting microsoft groups count more efficient #5109

vjeffrey opened this issue Jan 21, 2025 · 0 comments · May be fixed by #5153
Assignees
@afiune

Comments

@vjeffrey
Copy link
Contributor

vjeffrey commented Jan 21, 2025 •
edited
Loading

instead of listing all and getting the total we can make a specific resource for this and use the count api which should be much more performant

microsoft.groups.length
@vjeffrey vjeffrey changed the title use count API to make the response to microsoft.groups.length more efficient use count API to make getting microsoft groups count more efficient Jan 21, 2025
@afiune afiune self-assigned this Jan 31, 2025
afiune added a commit that referenced this issue Feb 3, 2025
@afiune
⚡️ improve microsoft.groups.length
8c655ba 
Closes #5109

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune added a commit that referenced this issue Feb 3, 2025
@afiune
⚡️ improve microsoft.groups.length
3d8e2ce 
Closes #5109

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
@afiune afiune linked a pull request Feb 3, 2025 that will close this issue
Open
afiune added a commit that referenced this issue Feb 3, 2025
@afiune
⚡️ improve microsoft.groups.length
f18085c 
Closes #5109

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune added a commit that referenced this issue Feb 3, 2025
@afiune
⚡️ improve microsoft.groups.length
679712c 
Closes #5109

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune added a commit that referenced this issue Feb 4, 2025
@afiune
⚡️ improve microsoft.applications.length
7e3f09a 
Depends on #5156
Contributes to #5109
Relates to #5153

Use Microsoft `$count` parameter to make `microsoft.applications.length` more performant.

https://learn.microsoft.com/en-us/graph/query-parameters?tabs=http#count-parameter

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
@afiune afiune mentioned this issue Feb 4, 2025
Open
afiune added a commit that referenced this issue Feb 21, 2025
@afiune
⚡️ improve microsoft.groups.length
a6b2e83 
Closes #5109

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune added a commit that referenced this issue Feb 22, 2025
@afiune
⚡️ improve microsoft.groups.length
13b710f 
Closes #5109

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afiune afiune

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚡️ improve microsoft.groups.length mondoohq/cnquery
2 participants
@afiune @vjeffrey