🧹 Rename the ec2-volume and ec2-snapshot platforms to be EBS #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API calls these EC2, which makes sense from an SDK organization standpoint, but doesn't reflect what these platforms are call. The console and documentation calls these EBS volumes/snapshots. This is a breaking change, but the blast radius is very small at this point since discover is not enabled by default. V10 is the perfect time to make this before we enable fine grained scanning by default. Signed-off-by: Tim Smith <tsmith84@gmail.com>
|
Makes sense to me ping @vjeffrey @preslavgerchev to make them aware as well. |
chris-rock
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API calls these EC2, which makes sense from an SDK organization standpoint, but doesn't reflect what these platforms are call. The console and documentation calls these EBS volumes/snapshots. This is a breaking change, but the blast radius is very small at this point since discover is not enabled by default. V10 is the perfect time to make this before we enable fine grained scanning by default.