🐛 return v9 portion in provider IDs #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a bug in cnquery/cnspec v9 where differences in the ID can cause
a crash:
```
panic: shell flag redefined: sudo
goroutine 1 [running]:
github.com/spf13/pflag.(*FlagSet).AddFlag(0xc000516200, 0xc000debb80)
/home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.6-0.20201009195203-85dd5c8bc61c/flag.go:855 +0x5ec
github.com/spf13/pflag.(*FlagSet).VarPF(0x10?, {0x22dbdc8, 0xc000afe960}, {0xc0006e72c8, 0x4}, {0x0, 0x0}, {0xc00005b2c0, 0x1d})
/home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.6-0.20201009195203-85dd5c8bc61c/flag.go:838 +0x14f
github.com/spf13/pflag.(*FlagSet).BoolVarP(0xc000afe938?, 0x5?, {0xc0006e72c8?, 0x1946360?}, {0x0?, 0x1dbe006?}, 0x33?, {0xc00005b2c0?, 0x3167bc0?})
/home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.6-0.20201009195203-85dd5c8bc61c/bool.go:55 +0x3e
github.com/spf13/pflag.(*FlagSet).BoolP(...)
/home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.6-0.20201009195203-85dd5c8bc61c/bool.go:80
github.com/spf13/pflag.(*FlagSet).Bool(...)
/home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.6-0.20201009195203-85dd5c8bc61c/bool.go:74
go.mondoo.com/cnquery/v9/cli/providers.attachFlag(0x0?, {{0xc0006e72c8, 0x4}, {0x0, 0x0}, {0xc0006e72d0, 0x5}, {0xc00005b2c0, 0x1d}, 0x1, ...})
```
This happens when e.g.:
```
→ /home/zero/.config/mondoo/providers (found 1 providers)
os 10.0.0 with connectors: local, ssh, winrm, vagrant, container, docker, filesystem
→ /opt/mondoo/providers (found 1 providers)
os 9.1.17 with connectors: local, ssh, winrm, vagrant, container, docker, filesystem
```
i.e. when we have an old-style provider ID (in v9.1.17) and a new-style
provider ID (which we tried to introduce with this version).
As soon as the ID is restored to be the same, this continue to work with
cnquery/cnspec v9.x. We will keep the old version tag in each provider
for the duration of v9.x support and remove the version indication from
the ID once it is sunset (i.e. when we release v11.0).
This may only be an edge-case with an easy solution/workaround, but it
is an annoying experience. We will suffer with a confusing ID for a
little bit until we can comfortably clean it up.
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
chris-rock
approved these changes
Jan 18, 2024
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bug in cnquery/cnspec v9 where differences in the ID can cause a crash:
This happens when e.g.:
i.e. when we have an old-style provider ID (in v9.1.17) and a new-style provider ID (which we tried to introduce with this version).
As soon as the ID is restored to be the same, this continue to work with cnquery/cnspec v9.x. We will keep the old version tag in each provider for the duration of v9.x support and remove the version indication from the ID once it is sunset (i.e. when we release v11.0).
This may only be an edge-case with an easy solution/workaround, but it is an annoying experience. We will suffer with a confusing ID for a little bit until we can comfortably clean it up.