Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix fetching of latest security score. #3069

Merged
merged 1 commit into from
Jan 19, 2024
Merged

🐛 Fix fetching of latest security score. #3069

merged 1 commit into from
Jan 19, 2024

Conversation

preslavgerchev
Copy link
Contributor

Fixes #3048 by ensuring we have the proper latest security score. Until now, we always fetched the earliest, not the latest one.

This PR also ensures that the secureScores resource is being re-used for latestSecureScore as well, saving a redundant API call towards MS graph

Signed-off-by: Preslav <preslav@mondoo.com>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @preslavgerchev

@chris-rock chris-rock merged commit 4198bb6 into main Jan 19, 2024
10 checks passed
@chris-rock chris-rock deleted the preslav/3048 branch January 19, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MS365 - inconsistencies in the Secure Scores
2 participants