🐛 make sure the os provider can be cross referenced from another provider #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is needed by the k8s provider since it is referencing the containerImage resource, which is defined in the os provider we also have the issue where filters that shouldn't be executed for an asset may request a provider that shouldn't be called. For example, trying to run aws filters on a k8s asset. This results in printing too many error messages, so I changed the log level of that error to debug Signed-off-by: Ivan Milchev <ivan@mondoo.com>
chris-rock
approved these changes
Jan 23, 2024
| @@ -588,11 +589,12 @@ func (r *Runtime) lookupResourceProvider(resource string) (*ConnectedProvider, * | |||
| // version support, we can safely remove this. | |||
| "go.mondoo.com/cnquery/v9/providers/core", | |||
| "go.mondoo.com/cnquery/v9/providers/network", | |||
| "go.mondoo.com/cnquery/v9/providers/os", | |||
There was a problem hiding this comment.
I think we need to review those resources that require it from the k8s provider.
There was a problem hiding this comment.
it's just containerImage resource that is referenced
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is needed by the k8s provider since it is referencing the containerImage resource, which is defined in the os provider
we also have the issue where filters that shouldn't be executed for an asset may request a provider that shouldn't be called. For example, trying to run aws filters on a k8s asset. This results in printing too many error messages, so I changed the log level of that error to debug