Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ use copy instead of proto.clone for property #3126

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Jan 26, 2024

Instead of using reflections to copy this object, manually copy the object instead. We have a bit more maintenance in the code, but gain a good chunk of speed and memory-friendliness with this approach.

Instead of using reflections to copy this object, manually copy the object instead. We have a bit more maintenance in the code, but gain a good chunk of speed and memory-friendliness with this approach.

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@arlimus arlimus requested a review from imilchev January 26, 2024 05:42
Copy link
Contributor

Test Results

744 tests  ±0   744 ✅ ±0   12s ⏱️ -1s
 83 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a9a488c. ± Comparison against base commit b130500.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:53:28_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:23:37_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:30:07_+0100_CET
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-01-25_18:20:48.911596648_+0100_CET_m=+0.010123347
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-25_18:20:48.911596648_+0100_CET_m=+0.010123347
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-25_18:20:48.911596648_+0100_CET_m=+0.010123347#01
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:00:00_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:07_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:09_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-01-26_05:44:36.119880407_+0000_UTC_m=+0.010983146
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-26_05:44:36.119880407_+0000_UTC_m=+0.010983146
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-26_05:44:36.119880407_+0000_UTC_m=+0.010983146#01

@imilchev imilchev merged commit a62e09b into main Jan 26, 2024
12 checks passed
@imilchev imilchev deleted the dom/noclone-property branch January 26, 2024 06:53
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants