Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix github provider by checking for nil errors #5006

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Dec 18, 2024

When workers return empty results with nil errors, the workerpool would return those
nil errors.

This change fixes that issue by not returning nil errors.

@afiune afiune changed the title 🐛 fix github provider by nil errors 🐛 fix github provider by nil errors Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Test Results

3 204 tests  +1   3 201 ✅ +1   1m 54s ⏱️ +8s
  379 suites ±0       3 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit cf83344. ± Comparison against base commit 9e11410.

♻️ This comment has been updated with latest results.

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
@afiune afiune changed the title 🐛 fix github provider by nil errors 🐛 fix github provider by checking for nil errors Dec 18, 2024
@afiune afiune merged commit 22fea38 into main Dec 18, 2024
17 checks passed
@afiune afiune deleted the afiune/github-fix branch December 18, 2024 19:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants