Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add additional field to GKE: releaseChannel #5111

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

mm-weber
Copy link
Contributor

@mm-weber mm-weber commented Jan 22, 2025

Adds this field:

cnspec> gcp.project.gke.clusters {releaseChannel}
gcp.project.gke.clusters: [
  0: {
    releaseChannel: {
      channel: "UNSPECIFIED"
    }
  }
]

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Test Results

3 206 tests  ±0   3 202 ✅ ±0   1m 42s ⏱️ -11s
  385 suites ±0       4 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit 85c310f. ± Comparison against base commit a6b5aed.

♻️ This comment has been updated with latest results.

Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
@mm-weber mm-weber force-pushed the manuel/gke-cluster-add-fields branch from d16c558 to 24776a7 Compare January 29, 2025 11:59
Signed-off-by: Preslav <preslav@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
@misterpantz
Copy link
Contributor

Thank you, @mm-weber. I'm the consistency police! 😆

@mm-weber mm-weber marked this pull request as draft January 29, 2025 15:20
@mm-weber
Copy link
Contributor Author

mm-weber commented Jan 29, 2025

Converted to draft adding more fields.

Nevermind all good.

@mm-weber mm-weber marked this pull request as ready for review January 29, 2025 15:24
@preslavgerchev preslavgerchev merged commit accac55 into main Jan 29, 2025
8 checks passed
@preslavgerchev preslavgerchev deleted the manuel/gke-cluster-add-fields branch January 29, 2025 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants