Skip to content

Commit 43023f4

Browse files
committed
fix: export types and rename MenuItem
1 parent 6004593 commit 43023f4

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export { useContextMenu } from './use-context-menu';
2+
export type { ContextMenuItem } from './types';

packages/compass-context-menu/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export type ContextMenuContext = {
1515
close(): void;
1616
};
1717

18-
export type MenuItem = {
18+
export type ContextMenuItem = {
1919
label: string;
2020
onAction: (event: React.KeyboardEvent | React.MouseEvent) => void;
2121
};

packages/compass-context-menu/src/use-context-menu.spec.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import { expect } from 'chai';
44
import sinon from 'sinon';
55
import { useContextMenu } from './use-context-menu';
66
import { ContextMenuProvider } from './context-menu-provider';
7-
import type { MenuItem } from './types';
7+
import type { ContextMenuItem } from './types';
88

99
describe('useContextMenu', function () {
10-
const TestMenu: React.FC<{ items: MenuItem[] }> = ({ items }) => (
10+
const TestMenu: React.FC<{ items: ContextMenuItem[] }> = ({ items }) => (
1111
<div data-testid="test-menu">
1212
{items.map((item, idx) => (
1313
<div
@@ -36,7 +36,7 @@ describe('useContextMenu', function () {
3636
onAction?: (id) => void;
3737
}) => {
3838
const contextMenu = useContextMenu({ Menu: TestMenu });
39-
const items: MenuItem[] = [
39+
const items: ContextMenuItem[] = [
4040
{
4141
label: 'Test Item',
4242
onAction: () => onAction?.(1),
@@ -64,7 +64,7 @@ describe('useContextMenu', function () {
6464
children?: React.ReactNode;
6565
}) => {
6666
const contextMenu = useContextMenu({ Menu: TestMenu });
67-
const parentItems: MenuItem[] = [
67+
const parentItems: ContextMenuItem[] = [
6868
{
6969
label: 'Parent Item 1',
7070
onAction: () => onAction?.(1),
@@ -90,7 +90,7 @@ describe('useContextMenu', function () {
9090
onAction?: (id: number) => void;
9191
}) => {
9292
const contextMenu = useContextMenu({ Menu: TestMenu });
93-
const childItems: MenuItem[] = [
93+
const childItems: ContextMenuItem[] = [
9494
{
9595
label: 'Child Item 1',
9696
onAction: () => onAction?.(1),

packages/compass-context-menu/src/use-context-menu.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import React, { useContext, useMemo, useRef } from 'react';
22
import { Context } from './context-menu-provider';
33
import { appendContextMenuContent } from './context-menu-content';
4-
import type { MenuItem } from './types';
4+
import type { ContextMenuItem } from './types';
55

6-
export type ContextMenuMethods<T extends MenuItem> = {
6+
export type ContextMenuMethods<T extends ContextMenuItem> = {
77
/**
88
* Close the context menu.
99
*/
@@ -15,7 +15,7 @@ export type ContextMenuMethods<T extends MenuItem> = {
1515
registerItems: (items: T[]) => (trigger: HTMLElement | null) => void;
1616
};
1717

18-
export function useContextMenu<T extends MenuItem>({
18+
export function useContextMenu<T extends ContextMenuItem>({
1919
Menu,
2020
}: {
2121
Menu: React.ComponentType<{

0 commit comments

Comments
 (0)