Skip to content

fix: limit definitions based on use COMPASS-8941 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Feb 10, 2025

Main change: Standard and Expanded convertors remember which definitions are actually used, so not everything is put into the $def section in the end.
Choices made:

  • keeping track of used definitions instead of traversing the schema at the end to pick the right ones -> I chose the former because the # of definitions is limited - schema is not
  • the used definitions could've been encapsulated with a function, I didn't have a preference and went with OOP because the SchemaAccessor is already OOP

Note: Big chunk of the diff is due to the change to objects. Hide whitespaces helps a little.

@paula-stacho paula-stacho marked this pull request as ready for review February 10, 2025 15:36
@paula-stacho paula-stacho merged commit d693c0d into main Feb 19, 2025
20 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8941 branch February 19, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants