MONGOCRYPT-784 avoid passing over-aligned bson_iter_t by value in parameters #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Nice catch, and thank you for the fix!
As of #926, enabling extra alignment is not the default for the bundled libbson. But I expect this could be triggered if using a system install of an over-aligned libbson. I request backporting the merged commit to r1.13 for the next patch release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves MONGOCRYPT-784.
Followup to #954, which introduced a by-value
bson_iter_tparameter for find_collections_in_pipeline which triggers the following MSVC warning whenENABLE_EXTRA_ALIGNMENTis enabled for the bson library: