MONGOCRYPT-783 address C99 standard conformance warnings #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdbmes
requested changes
Feb 28, 2025
| @@ -66,7 +63,7 @@ void mc_FLE2EncryptionPlaceholder_init(mc_FLE2EncryptionPlaceholder_t *placehold | |||
| memset(placeholder, 0, sizeof(mc_FLE2EncryptionPlaceholder_t)); | |||
| } | |||
|
|
|||
| #define ERROR_PREFIX "Error parsing FLE2EncryptionPlaceholder" | |||
| #define ERROR_PREFIX "Error parsing FLE2EncryptionPlaceholder: " | |||
There was a problem hiding this comment.
It looks like the extra ": " is missing from all of the ERROR_PREFIX except for this one.
There was a problem hiding this comment.
Good catch. Thank you!
mdbmes
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to MONGOCRYPT-783.
Addresses the following C standard conformance warnings for libmongocrypt:
-Wgnu-zero-variadic-macro-arguments: 13 unique, 2,741 total.-Wnewline-eof: 41 unique, 803 total.-Wpedanticfor object <-> function pointer conversion: 13 unique, 27 total.-Wextra-semi: 1 unique, 1 total.-Wpedanticfor__FUNCTION__: 27 unique, 19,974 total.-Wpedanticfor object <-> function pointer conversions: 3 unique, 29 total.-Wpedanticfor stray semicolon outside a function: 1 unique, 1 total.Remaining
-Wpedanticwarnings concerning anonymous structs and unions are addressed by #972.Most object <-> function pointer conversion warnings are concerned with specifying symbols which are loaded dynamically, as underlying functions require use of
void*even for function symbols. Themcr_dll_symfunction was split into an*_objand*_fnvariant accordingly so that the object -> function pointer cast can be isolated tomcr_dll_sym_fn. Other instances of such casts are converted into instances of-Wcast-strict-function-typeClang warnings (-Wpedanticfor GCC) which are silenced using the newMC_(BEGIN|END)_CAST_FUNCTION_TYPE_STRICT_IGNOREmacros.-Wgnu-zero-variadic-macro-argumentsClang warnings were introduced by #759. Most are easily addressed by deferring the enforcement of a format string argument to the underlying function being invoked (e.g._mongocrypt_set_error).TheReverted due to overlooking compiler compatibility for this warning flag.-Wvariadic-macro-arguments-omittedwarning is added toENABLE_MORE_WARNINGS_AS_ERRORSto further enforce at-least-one-argument-to-...standard conformance.The
CLIENT_ERR_PREFIXEDmacro inmc-rangeopts.crequired the most effort to address-Wgnu-zero-variadic-macro-argumentswarnings. TheCLIENT_ERR_PREFIXED(which is impossible to implement in a conforming manner) was instead replaced with a direct call toCLIENT_ERRwith an explicit prefix of theERROR_PREFIXmacro before the error message strings.