Add window support (2) #1636
Add window support (2) #1636
Conversation
|
It seems to go in the right direction. But it seems to be missing code on how to set this via webinterface? |
|
I pushed new changes as best as I could. If anything is missing could you complete it? Thanks @markirb |
|
Judging by the looks only this seems okay. Did you test this? Can you share screenshots of the HomeApp? |
|
Managed to get it working! Used "Display as" to switch between Roller Shutter and Window, just below name settings. Here is the screenshot when it's added as a Window.
I can now tell Siri to close/open my windows or blinds separately 😄 |
|
Very cool, thank you. I will review and try it in the next days hopefully and give it a short spin before this will be merged. |
| @@ -59,6 +63,7 @@ WindowCovering::WindowCovering(int id, Input *in0, Input *in1, Output *out0, | |||
| pm_open_ = pm1; | |||
| pm_close_ = pm0; | |||
| } | |||
| set_primary(true); | |||
There was a problem hiding this comment.
Is this really needed? If so why?
There was a problem hiding this comment.
is it because it is a security device? if so can you please make this conditional only for the window and not the cover
As discussed on #766
The functionality would be really useful but there have been no follow-ups since 2021...
This entirely escaped my knowledge, but I tried to do it without duplicating window_covering.
Can @rojer @markirb confirm it works as expected?
Thanks in advance and sorry if there are any inconveniences. I have little to no idea what I'm doing.