Fix some template declarations not setting namespace

[duckdoom5]

Also added a minor optimization since adding the GetNamespace() calls slowed it down a lot

[duckdoom5]

How do we update bindings for other platforms? Can I just generate them on my windows device?

[duckdoom5]

Should we maybe automate generating all parser bindings as well?

[tritao]

How do we update bindings for other platforms? Can I just generate them on my windows device?

Yes, and yes, get the headers package here: https://github.com/mono/CppSharp/releases/download/CppSharp/headers.zip

I think it needs to be extracted to build/ and then Parser.Gen should automatically pick it up.

We once had it setup so they would get automatically generated as part of the build, or maybe as a post-commit hook.

But it caused issues and we eventually took it out.

These days I think it would work quite well as a pre-commit hook that automatically updates a PR branch with the latest bindings.

[duckdoom5]

Hm, the linux version gives me errors

C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/cdefs.h(763,2): error: Unsupported architecture
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\machine/_types.h(34,2): error: architecture not supported
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(55,9): error: unknown type name '__int64_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(56,9): error: unknown type name '__int32_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(57,9): error: unknown type name '__int32_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(60,9): error: unknown type name '__uint32_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(61,9): error: unknown type name '__uint32_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(62,9): error: unknown type name '__uint64_t'; did you mean 'uint64_t'?
...
...

[tritao]

Hm, the linux version gives me errors

C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/cdefs.h(763,2): error: Unsupported architecture
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\machine/_types.h(34,2): error: architecture not supported
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(55,9): error: unknown type name '__int64_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(56,9): error: unknown type name '__int32_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(57,9): error: unknown type name '__int32_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(60,9): error: unknown type name '__uint32_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(61,9): error: unknown type name '__uint32_t'
C:\SSD_WorkProjects\CppSharp\build\headers\osx\include\sys/_types.h(62,9): error: unknown type name '__uint64_t'; did you mean 'uint64_t'?
...
...

I assume you meant macOS, right?

[duckdoom5]

Hah, yes XD. Though linux also gives me an error:

C:\SSD_WorkProjects\CppSharp\build\headers\x86_64-linux-gnu/usr/include\gnu/stubs.h(7,11): fatal: 'gnu/stubs-32.h' file not found

[duckdoom5]

Both errors occur when building ARM64. The others work fine

Generating the C# parser bindings for OSX ARM64...
Generating the C# parser bindings for Linux ARM64...
Generating the C# parser bindings for Linux ARM64 (GCC C++11 ABI)...

[tritao]

Both errors occur when building ARM64. The others work fine

Generating the C# parser bindings for OSX ARM64...
Generating the C# parser bindings for Linux ARM64...
Generating the C# parser bindings for Linux ARM64 (GCC C++11 ABI)...

Yes, we updated the headers package recently for ARM64, I think that version I linked is the old one, but am not finding the updated one, I'll see if I can find it.

[duckdoom5]

Also, shouldn't we set the target arch compiler flag here?

[duckdoom5]

I noticed arm64 is not part of the CI. Should we add those?

[tritao]

About the headers, I might have been thinking about: #1825 (comment)

I have built a new package with the headers from that link, but updated the macOS headers with recent macOS ARM64 ones too, can you see if this helps?

headers.zip

Though you updated the PR now and its green now, did you fix it manually?

I noticed arm64 is not part of the CI. Should we add those?

I am not sure what's the status on it, see #1825 maybe.

For macOS it's not possible either until we generally get #1879.

We can get the generator to work in macOS ARM64 by not relying on std::string for parser bindings (as it once was), but generally for all tests to work, CppSharp will need a separate C-ABI bindings generation mode. See the whole saga at dotnet/runtime#106471.

[duckdoom5]

Though you updated the PR now and its green now, did you fix it manually?

Yeah, so with the old header package I was able to generate the non-arm64 bindings for osx and linux.

They are green cus the arm64 bindings don't get tested by CI.

I'm off for the weekend though, and I currently have no interest in the arm64 version so if I can leave that for someone else that'd be great, but I understand wanting to keep them in sync so lmk.

[tritao]

Though you updated the PR now and its green now, did you fix it manually?

Yeah, so with the old header package I was able to generate the non-arm64 bindings for osx and linux.

They are green cus the arm64 bindings don't get tested by CI.

I'm off for the weekend though, and I currently have no interest in the arm64 version so if I can leave that for someone else that'd be great, but I understand wanting to keep them in sync so lmk.

Neither do I at the moment, so I think we're good 👍

If you generate the bindings again, do use this new package so we can at least keep it in sync as you said.