[docs] replace old docs links with their new counterparts #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegenberg
force-pushed
the
fix-link-in-template
branch
from
2a7c41c to
8b1d5f5
Compare
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
sarjona
requested changes
Feb 3, 2025
There was a problem hiding this comment.
HI @ziegenberg!
Thanks a lot for fixing these old links. Could you please remove the version for the git one to merge this? TIA! :-)
The reply templates for pasting into the tracker still had the old links to docs.moodle.org/dev. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
fix-link-in-template
branch
from
8b1d5f5 to
c24d0ee
Compare
sarjona
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Hi @ziegenberg!
Thanks a lot for working on this and removing the version from the URL. I'm happy to approve this change now :-)
andrewnicols
reviewed
Feb 5, 2025
| @@ -330,7 +330,7 @@ Once the issue is ready for integration, you can submit it to integration on beh | |||
|
|
|||
| ``` | |||
| Thanks for providing a patch. | |||
| I have reviewed your code and can confirm that it addresses the reported issue. We would like to include it in core. Moodle values its contributors and tries to give them credit when possible. If you are interested in your name appearing on the https://moodle.org/dev/contributions.php page you can create a git commit that we will then pull into Moodle. You can learn more about Git and how Moodle uses it at [Git for developers|https://docs.moodle.org/dev/Git_for_developers] page. Please let me know if you want to prepare a git branch. Or if you don't have time to go through the whole process at the moment I can pick your patch myself. | |||
| I have reviewed your code and can confirm that it addresses the reported issue. We would like to include it in core. Moodle values its contributors and tries to give them credit when possible. If you are interested in your name appearing on the https://moodle.org/dev/contributions.php page you can create a git commit that we will then pull into Moodle. You can learn more about Git and how Moodle uses it at [Git for developers|https://moodledev.io/docs/guides/git] page. Please let me know if you want to prepare a git branch. Or if you don't have time to go through the whole process at the moment I can pick your patch myself. | |||
There was a problem hiding this comment.
Err this is wrong.
Do not use these kinds of links to the devdocs. Use absolute or relative. In this case, absolute:
/docs/guides/git
Not
https://moodledev.io/docs/guides/git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reply templates for pasting into the tracker still had the old links to docs.moodle.org/dev.