When trying to use this tool on anything other than Travis it is hard…

[kiklop74]

…er to make ci script look lean because so many options have to be crammed in the install command line.

It would be most useful to have more install options mapped to ENV variables.

Fixes #217

[codecov]

Codecov Report

Merging #218 (942cfdf) into master (409180a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #218      +/-   ##
============================================
+ Coverage     84.51%   84.55%   +0.03%     
- Complexity      683      688       +5     
============================================
  Files            74       74              
  Lines          2125     2130       +5     
============================================
+ Hits           1796     1801       +5     
  Misses          329      329              

Impacted Files	Coverage Δ
src/Command/InstallCommand.php	99.09% <100.00%> (+0.04%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[stronk7]

Hi @kiklop74 ,

I've rebased your original branch and have added a couple of (fixup) commits to it:

1. About to use camelCase variables in the Installer command.
2. About to briefly document the new env variables in changelog and travis/gha explained docs.

If they look ok for you, I can squash all (3 commits) changes together and proceed with this.

Ciao :-)

[scara]

Hi @stronk7,
what about deprecating DB to use DB_TYPE with a plan to remove DB bc in the future?
It would be consistent with the CLI arguments counterpart.

HTH,
Matteo

[kiklop74]

@stronk7 this all looks great. Go ahead and do whatever you had in mind.

[stronk7]

what about deprecating DB to use DB_TYPE with a plan to remove DB bc in the future?

+1 to create issue about that, indeed!

[stronk7]

I've created #229 about the move from existing DB to a new DB_TYPE env var, for the records.

[stronk7]

@kiklop74 ,

I've squashed the 3 commits (original + 2 fixups) into 1 and I'll proceed to review and merge this soon.

Ciao :-)

[stronk7]

Done, I've left the command options as there where (without the (DB_XXXX env var) comment). The references in the "explained" files should be enough. Maybe, at some point, we should consider to add a new docs page with a list of all the available ENV variables, right now their docs are spread over multiple files.

[stronk7]

Thanks all, merging this...