closest_on_segment: fix -1 case

felixguendling · felixguendling · commit 10fde5b46782 · 2024-07-07T22:31:04.000+02:00
diff --git a/src/latlng.cc b/src/latlng.cc
@@ -98,11 +98,15 @@ latlng closest_on_segment(latlng const& x, latlng const& segment_from,
       seg_dir.dot(start_vec) / (seg_len * start_vec.length());
   if (start_rel >= 1 - kEpsilon) {
     return segment_from;
+  } else if (start_rel <= -1 + kEpsilon) {
+    return segment_to;
   }
 
   auto const end_rel = seg_dir.dot(end_vec) / (seg_len * end_vec.length());
   if (end_rel >= 1 - kEpsilon) {
     return segment_to;
+  } else if (end_rel <= -1 + kEpsilon) {
+    return segment_from;
   }
 
   auto const start_angle = std::acos(start_rel);

Original file line number	Diff line number	Diff line change
`@@ -98,11 +98,15 @@ latlng closest_on_segment(latlng const& x, latlng const& segment_from,`
`98`	`98`	`seg_dir.dot(start_vec) / (seg_len * start_vec.length());`
`99`	`99`	`if (start_rel >= 1 - kEpsilon) {`
`100`	`100`	`return segment_from;`
	`101`	`+ } else if (start_rel <= -1 + kEpsilon) {`
	`102`	`+ return segment_to;`
`101`	`103`	`}`
`102`	`104`
`103`	`105`	`auto const end_rel = seg_dir.dot(end_vec) / (seg_len * end_vec.length());`
`104`	`106`	`if (end_rel >= 1 - kEpsilon) {`
`105`	`107`	`return segment_to;`
	`108`	`+ } else if (end_rel <= -1 + kEpsilon) {`
	`109`	`+ return segment_from;`
`106`	`110`	`}`
`107`	`111`
`108`	`112`	`auto const start_angle = std::acos(start_rel);`