Merge pull request #326 from pschmitt/fix-ssh-options

Don't pass invalid options to the SSH binary
moul · Oct 13, 2019 · 334dc49 · 334dc49
2 parents 36647a1 + 2545aa8
commit 334dc49
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/pkg/commands/wrapper.go b/pkg/commands/wrapper.go
@@ -46,6 +46,14 @@ func runSSHWrapperCommand(cmd *cobra.Command, args []string) error {
 	}
 	for _, flag := range config.SSHStringFlags {
 		for _, val := range viper.GetStringSlice(flag) {
+			if (flag == "o" || flag == "O") && val == "false" {
+				logger().Debug(
+					"Skip invalid option:",
+					zap.String("flag", flag),
+					zap.String("val", val),
+				)
+				continue
+			}
 			options = append(options, fmt.Sprintf("-%s", flag))
 			options = append(options, val)
 		}