Skip to content

Updated to use Bootstrap 4 classes #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated to use Bootstrap 4 classes #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ad4b83
Updated to use Bootstrap 4 classes
jasonsperske Apr 12, 2018
58df853
tiny format update to make it work better on mobile
jasonsperske Apr 14, 2018
e1f0558
bumped required bootstrap version
jasonsperske Apr 14, 2018
a8d0877
removed unused bootstrap sizing classes
jasonsperske Apr 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Bootstrap Notify
This is a simple plugin that turns standard Bootstrap alerts into "Growl-like" notifications.
This is a simple plugin that turns standard Bootstrap 4.0 alerts into "Growl-like" notifications.

## Manual Download - Stable Release
If toy would like to download the latest stable release please follow the link below
Expand All @@ -21,6 +21,8 @@ meteor add mouse0270:bootstrap-notify
```

## Changelog
#### Version 4.0.0
- Updated template to match Bootstrap 4 CSS classes
#### Version 3.1.5 provided by [chrismbarr](https://github.com/chrismbarr) - *Testing*
- Cleaned Up Code
- Fixed Spelling
Expand Down Expand Up @@ -119,11 +121,11 @@ transition: all 0.5 ease-in-out;
- [Demo](http://bootstrap-growl.remabledesigns.com/)
- [Documentation](http://bootstrap-notify.remabledesigns.com/#documentation)

NOTE: Some users have reported an issue where the demo/documentation links repsond with only `pageok` in the body. If that occurs for you, try emptying your browser cache or an alternate browser.
NOTE: Some users have reported an issue where the demo/documentation links repsond with only `pageok` in the body. If that occurs for you, try emptying your browser cache or an alternate browser.

## Dependencies
- [jQuery v1.10.2](http://jquery.com/)
- [Bootstrap v2.0.0 - 3.2.0](http://getbootstrap.com/)
- [Bootstrap v4.0.0](http://getbootstrap.com/)

## Copyright and License
The MIT License (MIT)
Expand Down
18 changes: 14 additions & 4 deletions bootstrap-notify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Project: Bootstrap Notify = v3.1.5
* Project: Bootstrap Notify = v4.0.0
* Description: Turns standard Bootstrap alerts into "Growl-like" notifications.
* Author: Mouse0270 aka Robert McIntosh
* License: MIT License
Expand Down Expand Up @@ -50,7 +50,19 @@
onClosed: null,
onClick: null,
icon_type: 'class',
template: '<div data-notify="container" class="col-xs-11 col-sm-4 alert alert-{0}" role="alert"><button type="button" aria-hidden="true" class="close" data-notify="dismiss">&times;</button><span data-notify="icon"></span> <span data-notify="title">{1}</span> <span data-notify="message">{2}</span><div class="progress" data-notify="progressbar"><div class="progress-bar progress-bar-{0}" role="progressbar" aria-valuenow="0" aria-valuemin="0" aria-valuemax="100" style="width: 0%;"></div></div><a href="{3}" target="{4}" data-notify="url"></a></div>'
template: [
'<div data-notify="container">',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the classes are missing for correct width

col-11 col-sm-4

'<div class="alert alert-{0}" role="alert">',
'<button type="button" aria-hidden="true" class="close" data-notify="dismiss">&times;</button>',
'<span data-notify="icon"></span>',
'<h4 class="alert-heading" data-notify="title">{1}</h4>',
'<p data-notify="message">{2}</p>',
'<div class="progress" data-notify="progressbar">',
'<div class="progress-bar progress-bar-{0}" role="progressbar" aria-valuenow="0" aria-valuemin="0" aria-valuemax="100" style="width: 0%;"></div>',
'</div>',
'<a href="{3}" target="{4}" data-notify="url"></a>',
'</div>',
'</div>'].join('')
};

String.format = function () {
Expand Down Expand Up @@ -413,5 +425,3 @@


}));


Loading