Skip to content

Improve docstrings in moveit_py '.pyi' stubs for better usability #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VibhuSharma19
Copy link

docs(moveit_py): enhance .pyi stub files with detailed doc-strings

This commit improves the type stub files (.pyi) within the moveit_py package by adding comprehensive doc-strings for all public classes, methods, and properties. The enhancements include:

  • Usage descriptions for classes and interfaces
  • Argument details with types and purpose
  • Return value descriptions
  • Improved clarity for users relying on static analysis tools (e.g. mypy, Pyright)
  • Better integration with editor IntelliSense and autocomplete features

These changes aim to improve developer experience, maintainability, and usability of the Python interface of MoveIt. No changes were made to runtime behavior.

Signed-off-by: Vibhu Sharma 1999vibhusharma@gmail.com

Description

This pull request enhances the type stub files (.pyi) in the moveit_py package by adding comprehensive and standardized doc-strings for all public-facing classes, methods, and properties.

These improvements provide detailed information such as:

  • Purpose and usage of classes/interfaces
    
  • Argument names, types, and descriptions
    
  • Return value documentation
    
  • Semantic clarity for developers and contributors
    

Motivation

This change is intended to:

  • Enable rich IntelliSense/autocomplete in editors like VSCode 
    
  • Serve as inline documentation for better onboarding and usage understanding
    
  • Ensure the moveit_py Python interface is easier to use and maintain
    

Runtime Impact

No changes were made to runtime behavior.
This is a purely documentation-oriented update confined to .pyi files.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.84%. Comparing base (89acadd) to head (1285d0a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3424      +/-   ##
==========================================
- Coverage   45.86%   45.84%   -0.01%     
==========================================
  Files         717      717              
  Lines       62628    62628              
  Branches     7580     7580              
==========================================
- Hits        28715    28705      -10     
- Misses      33748    33756       +8     
- Partials      165      167       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VibhuSharma19 VibhuSharma19 force-pushed the improved_docstring_moveitpy branch from 1285d0a to 3c27faa Compare April 8, 2025 02:13
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Some minor comments only.

@VibhuSharma19 VibhuSharma19 requested a review from rhaschke April 9, 2025 10:00
VibhuSharma19 and others added 3 commits April 22, 2025 16:10
…sability

docs(moveit_py): enhance .pyi stub files with detailed docstrings

This commit improves the type stub files (.pyi) within the `moveit_py` package by adding comprehensive docstrings for all public classes, methods, and properties. The enhancements include:

- Usage descriptions for classes and interfaces
- Argument details with types and purpose
- Return value descriptions
- Improved clarity for users relying on static analysis tools (e.g. mypy, Pyright)
- Better integration with editor IntelliSense and autocomplete features

These changes aim to improve developer experience, maintainability, and usability of the Python interface of MoveIt. No changes were made to runtime behavior.

Signed-off-by: Vibhu Sharma 1999vibhusharma@gmail.com
@VibhuSharma19 VibhuSharma19 force-pushed the improved_docstring_moveitpy branch from 814e105 to 5730ce7 Compare April 22, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants