ENG-251 aptos-logger: cut out async logging #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
force-pushed
the
mikhail/trim-aptos-logger
branch
from
4afa406 to
bd3e72f
Compare
|
Integration: movementlabsxyz/movement#41 |
|
This is working for me. |
l-monninger
pushed a commit
that referenced
this pull request
Jul 2, 2024
* [move] fixes to `randomness.move` (aptos-labs#12250) * [move] fixes to randomness.move * Fixed the Prover spec Fixed the spec to unblock the PR. Need to prove the introduced assumptions with proper loop invariants, which should be provable. * lint --------- Co-authored-by: Junkil Park <juki14@gmail.com> Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com> * fix specs --------- Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com> Co-authored-by: Junkil Park <juki14@gmail.com> Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove async functionality from
async-logger, making it more suitable for dependent crates ported to RISC0.Cutting the code out is a quicker alternative, also the architecture is simplified (should be closer to
tracingthat does not inherently require async).Test Plan
Integration branch on movement SDK, check that logs are being produced.