Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Move warnings in Governed Gas Pool module and spec #129

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

andygolay
Copy link

@andygolay andygolay commented Jan 28, 2025

Description

  • Clean up various Move warnings in governed_gas_pool.move and governed_gas_pool.spec.move

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • [ x] Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • [ x] Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

movement move test

Key Areas to Review

Checklist

  • [x ] I have read and followed the CONTRIBUTING doc
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x] I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • [ x] I have made corresponding changes to the documentation

Outstanding issues:

In aptos-move/e2e-move-tests, cargo test fails with an unrelated error that also appears in the Aptos Labs aptos-core repo. Issue opened here: #130

@andygolay andygolay marked this pull request as ready for review January 28, 2025 12:42
@0xmovses 0xmovses mentioned this pull request Jan 28, 2025
21 tasks
@0xmovses 0xmovses self-requested a review January 28, 2025 13:21
@0xmovses 0xmovses merged commit 7722fb4 into movement Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants