Destroying mint cap evaluation #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygolay
reviewed
Mar 4, 2025
|
|
||
| Finally, we the evaluate the following potential usages of the Aptos Coin mint capability as would affect critical system properties. These are: | ||
|
|
||
| 1. **[Transaction `prologue` and `epilogue`](#transaction-epilogue-and-prologue):** we assert that destroying the mint capability would cause failures of the transaction `prologue` and `epilogue` and thus general transaction processing under the Governed Gas Pool feature flags. |
There was a problem hiding this comment.
Should this be "we assert that destroying the mint capability would NOT cause failures of the transaction" @l-monninger ?
There was a problem hiding this comment.
Yes, crucial NOT.
There was a problem hiding this comment.
This just got merged without that change going in @l-monninger @0xmovses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Destroying mint cap evaluation