Pass FinalityMode by value in executors

Derive copy on the enum as well.

Author: mzabaluev

networks/monza/monza-full-node/src/partial.rs

@@ -166,7 +166,7 @@ impl <T : MonzaExecutor + Send + Sync + Clone>MonzaPartialNode<T> {
             );
             let block_id = executable_block.block_id;
             self.executor.execute_block(
-                &FinalityMode::Opt,
+                FinalityMode::Opt,
                 executable_block
             ).await?;
 

networks/suzuka/suzuka-full-node/src/partial.rs

@@ -166,7 +166,7 @@ impl <T : SuzukaExecutor + Send + Sync + Clone>SuzukaPartialNode<T> {
             );
             let block_id = executable_block.block_id;
             self.executor.execute_block(
-                &FinalityMode::Opt,
+                FinalityMode::Opt,
                 executable_block
             ).await?;
 

protocol-units/execution/maptos/util/src/finality_mode.rs

@@ -1,4 +1,4 @@
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Copy, Clone, PartialEq, Eq)]
 pub enum FinalityMode {
     Dyn,
     Opt,

protocol-units/execution/monza/executor/src/lib.rs

@@ -24,7 +24,7 @@ pub trait MonzaExecutor {
     /// Executes a block dynamically
     async fn execute_block(
         &self,
-        mode : &FinalityMode, 
+        mode: FinalityMode, 
         block: ExecutableBlock,
     ) -> Result<(), anyhow::Error>;
 

protocol-units/execution/monza/executor/src/v1.rs

@@ -43,7 +43,7 @@ impl MonzaExecutor for MonzaExecutorV1 {
 	/// Executes a block dynamically
 	async fn execute_block(
 		&self,
-		mode: &FinalityMode,
+		mode: FinalityMode,
 		block: ExecutableBlock,
 	) -> Result<(), anyhow::Error> {
 		match mode {
@@ -131,15 +131,15 @@ mod tests {
 
 	#[tokio::test]
 	async fn test_execute_opt_block() -> Result<(), anyhow::Error> {
-		let (tx, rx) = async_channel::unbounded();
-		let mut executor = MonzaExecutorV1::try_from_env(tx).await?;
+		let (tx, _rx) = async_channel::unbounded();
+		let executor = MonzaExecutorV1::try_from_env(tx).await?;
 		let block_id = HashValue::random();
 		let tx = SignatureVerifiedTransaction::Valid(Transaction::UserTransaction(
 			create_signed_transaction(0),
 		));
 		let txs = ExecutableTransactions::Unsharded(vec![tx]);
 		let block = ExecutableBlock::new(block_id.clone(), txs);
-		executor.execute_block(&FinalityMode::Opt, block).await?;
+		executor.execute_block(FinalityMode::Opt, block).await?;
 		Ok(())
 	}
 
@@ -212,7 +212,7 @@ mod tests {
 			SignatureVerifiedTransaction::Valid(Transaction::UserTransaction(received_transaction));
 		let txs = ExecutableTransactions::Unsharded(vec![tx]);
 		let block = ExecutableBlock::new(block_id.clone(), txs);
-		executor.execute_block(&FinalityMode::Opt, block).await?;
+		executor.execute_block(FinalityMode::Opt, block).await?;
 
 		services_handle.abort();
 		background_handle.abort();
@@ -274,7 +274,7 @@ mod tests {
 			));
 			let txs = ExecutableTransactions::Unsharded(vec![tx]);
 			let block = ExecutableBlock::new(block_id.clone(), txs);
-			executor.execute_block(&FinalityMode::Opt, block).await?;
+			executor.execute_block(FinalityMode::Opt, block).await?;
 
 			blockheight += 1;
 			committed_blocks.insert(

protocol-units/execution/suzuka/executor/src/lib.rs

@@ -24,7 +24,7 @@ pub trait SuzukaExecutor {
     /// Executes a block dynamically
     async fn execute_block(
         &self,
-        mode : &FinalityMode, 
+        mode: FinalityMode, 
         block: ExecutableBlock,
     ) -> Result<(), anyhow::Error>;
 

protocol-units/execution/suzuka/executor/src/v1.rs

@@ -48,7 +48,7 @@ impl SuzukaExecutor for SuzukaExecutorV1 {
     /// Executes a block dynamically
     async fn execute_block(
         &self,
-        mode : &FinalityMode, 
+        mode: FinalityMode, 
         block: ExecutableBlock,
     ) -> Result<(), anyhow::Error> {
 
@@ -137,15 +137,15 @@ mod opt_tests {
 
 	#[tokio::test]
 	async fn test_execute_opt_block() -> Result<(), anyhow::Error> {
-        let (tx, rx) = async_channel::unbounded();
-		let mut executor = SuzukaExecutorV1::try_from_env(tx).await?;
+        let (tx, _rx) = async_channel::unbounded();
+		let executor = SuzukaExecutorV1::try_from_env(tx).await?;
 		let block_id = HashValue::random();
 		let tx = SignatureVerifiedTransaction::Valid(Transaction::UserTransaction(
 			create_signed_transaction(0),
 		));
 		let txs = ExecutableTransactions::Unsharded(vec![tx]);
 		let block = ExecutableBlock::new(block_id.clone(), txs);
-		executor.execute_block(&FinalityMode::Opt, block).await?;
+		executor.execute_block(FinalityMode::Opt, block).await?;
 		Ok(())
 	}
 
@@ -228,7 +228,7 @@ mod opt_tests {
         ));
         let txs = ExecutableTransactions::Unsharded(vec![tx]);
         let block = ExecutableBlock::new(block_id.clone(), txs);
-        executor.execute_block(&FinalityMode::Opt, block).await?;
+        executor.execute_block(FinalityMode::Opt, block).await?;
 
         services_handle.abort();
         background_handle.abort();